Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(369)

Issue 2678273011: Move service_worker_type_converters to content/renderer to avoid WebString() usage in browser (Closed)

Created:
10 months ago by scottmg
Modified:
10 months ago
Reviewers:
michaeln, jam, Will Harris
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, iclelland+watch_chromium.org, serviceworker-reviews, chasej+watch_chromium.org, nhiroki, Peter Beverloo, kinuko+serviceworker, darin-cc_chromium.org, jkarlin+watch_chromium.org, horo+watch_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move service_worker_type_converters to content/renderer to avoid WebString() usage in browser This is just a simple move as the functions were unreferenced in the browser. R=jam@chromium.org, wfh@chromium.org BUG=248653 Review-Url: https://codereview.chromium.org/2678273011 Cr-Commit-Position: refs/heads/master@{#449751} Committed: https://chromium.googlesource.com/chromium/src/+/c02aa3d0557d8f3b5ea70e3a362700f2f87cc310

Patch Set 1 #

Patch Set 2 : move _type_converter security OWNERS entry to renderer/ too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -199 lines) Patch
M content/browser/background_sync/background_sync_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/service_worker/OWNERS View 1 1 chunk +0 lines, -3 lines 0 comments Download
D content/common/service_worker/service_worker_type_converters.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/common/service_worker/service_worker_type_converters.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/service_worker/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 2 chunks +1 line, -1 line 0 comments Download
A + content/renderer/service_worker/service_worker_type_converters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/service_worker/service_worker_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (13 generated)
scottmg
wfh: for OWNERS stamp for _type_converters jam: the rest
10 months ago (2017-02-10 19:52:06 UTC) #4
Will Harris
On 2017/02/10 19:52:06, scottmg wrote: > wfh: for OWNERS stamp for _type_converters > jam: the ...
10 months ago (2017-02-10 19:54:30 UTC) #5
jam
lgtm
10 months ago (2017-02-10 19:57:32 UTC) #6
scottmg
Oops, +michaeln: Had to move the OWNERS entry for _type_converter.* too, so I need an ...
10 months ago (2017-02-10 20:05:41 UTC) #8
jam
On 2017/02/10 20:05:41, scottmg wrote: > Oops, +michaeln: Had to move the OWNERS entry for ...
10 months ago (2017-02-10 21:03:49 UTC) #11
scottmg
On 2017/02/10 21:03:49, jam wrote: > On 2017/02/10 20:05:41, scottmg wrote: > > Oops, +michaeln: ...
10 months ago (2017-02-10 21:06:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678273011/20001
10 months ago (2017-02-10 21:07:30 UTC) #17
scottmg
(Looks like jam's lgtm is good enough for that, so no TBR needed. All very ...
10 months ago (2017-02-10 21:12:18 UTC) #19
commit-bot: I haz the power
10 months ago (2017-02-10 22:09:11 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c02aa3d0557d8f3b5ea70e3a3627...

Powered by Google App Engine
This is Rietveld 0eb02b776