Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2688803004: Move usage of WebString methods into renderer for FrameOwnerProperties (Closed)

Created:
3 years, 10 months ago by scottmg
Modified:
3 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move usage of WebString methods into renderer for FrameOwnerProperties BUG=248653 Review-Url: https://codereview.chromium.org/2688803004 Cr-Commit-Position: refs/heads/master@{#449724} Committed: https://chromium.googlesource.com/chromium/src/+/aacca53a65484d3f43f751e6bbcdfd7e22b0afd1

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Patch Set 4 : fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -39 lines) Patch
M content/common/frame_owner_properties.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/frame_owner_properties.cc View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A content/renderer/frame_owner_properties.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
A content/renderer/frame_owner_properties.cc View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 5 chunks +10 lines, -4 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (21 generated)
scottmg
3 years, 10 months ago (2017-02-10 19:14:20 UTC) #18
jam
lgtm
3 years, 10 months ago (2017-02-10 19:38:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688803004/40002
3 years, 10 months ago (2017-02-10 19:43:06 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 20:41:48 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:40002) as
https://chromium.googlesource.com/chromium/src/+/aacca53a65484d3f43f751e6bbcd...

Powered by Google App Engine
This is Rietveld 408576698