Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 2678273004: Remove unused methods in webkitpy/layout_tests/. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused methods in webkitpy/layout_tests/. BUG=677561 Review-Url: https://codereview.chromium.org/2678273004 Cr-Commit-Position: refs/heads/master@{#448820} Committed: https://chromium.googlesource.com/chromium/src/+/7dac5cba044e8882732a727db22c2d578d693dec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -80 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 3 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
qyearsley
3 years, 10 months ago (2017-02-07 23:09:11 UTC) #3
jeffcarp
lgtm
3 years, 10 months ago (2017-02-07 23:43:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678273004/1
3 years, 10 months ago (2017-02-08 00:04:01 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 00:37:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7dac5cba044e8882732a727db22c...

Powered by Google App Engine
This is Rietveld 408576698