third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py - Issue 2678273004: Remove unused methods in webkitpy/layout_tests/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 2678273004: Remove unused methods in webkitpy/layout_tests/. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

index 7ef3b7809cf11ec3348c7533041bf86a9117304d..fd8fb7c398a3d628eb0da45bb46c6d96fe91be17 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

@@ -54,12 +54,6 @@ class PortTest(unittest.TestCase):

return TestPort(host, **kwargs)

return Port(host, port_name or 'baseport', **kwargs)

- def _file_with_contents(self, contents, encoding="utf-8"):

- new_file = tempfile.NamedTemporaryFile()

- new_file.write(contents.encode(encoding))

- new_file.flush()

- return new_file

def test_pretty_patch_os_error(self):

port = self.make_port(executive=MockExecutive(exception=OSError))

oc = OutputCapture()