Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2678273004: Remove unused methods in webkitpy/layout_tests/. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
index 3c4728110f8fdb520e419a308666237faa51b436..329d27cdf65d1d2fda5a7e2cd5f321f83c4788bc 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -343,10 +343,6 @@ class Port(object):
return False
return True
- def _check_port_build(self):
- # Ports can override this method to do additional checks.
- return True
-
def check_sys_deps(self, needs_http):
"""Checks whether the system is properly configured.
@@ -1262,9 +1258,6 @@ class Port(object):
test_configurations.append(TestConfiguration(version, architecture, build_type))
return test_configurations
- def warn_if_bug_missing_in_test_expectations(self):
- return True
-
def _flag_specific_expectations_files(self):
return [self._filesystem.join(self.layout_tests_dir(), 'FlagExpectations', flag.lstrip('-'))
for flag in self.get_option('additional_driver_flag', [])]
@@ -1650,11 +1643,6 @@ class Port(object):
pass
return True
- def _chromium_baseline_path(self, platform):
- if platform is None:
- platform = self.name()
- return self.path_from_webkit_base('LayoutTests', 'platform', platform)
-
class VirtualTestSuite(object):

Powered by Google App Engine
This is Rietveld 408576698