Refactoring recent tabs eg tests.

Refactoring recent tabs eg tests.

From comments in CL https://codereview.chromium.org/2677933003/

BUG=none

Review-Url: https://codereview.chromium.org/2678033002
Cr-Commit-Position: refs/heads/master@{#448278}
Committed: https://chromium.googlesource.com/chromium/src/+/4a566253e6c5dc608fdc159696c67703318a1958

[lody, 2017-02-06 15:45:49]

lod@chromium.org changed reviewers:
+ sdefresne@chromium.org

[lody, 2017-02-06 15:45:50]

Changes from other CL 😺

[sdefresne, 2017-02-06 15:54:36]

https://codereview.chromium.org/2678033002/diff/1/ios/chrome/browser/ui/ntp/r...
File
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm
(right):

https://codereview.chromium.org/2678033002/diff/1/ios/chrome/browser/ui/ntp/r...
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:81:
std::string(kHTMLOfTestPage)}});
nit: can you put a comma after the first "}", i.e.
"std::string(kHTMLOfTestPage)},});" (though clang-format will reformat this once
you introduce the comma :-)).

https://codereview.chromium.org/2678033002/diff/1/ios/chrome/browser/ui/ntp/r...
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:82:
responses[testPageURL] = std::string(kHTMLOfTestPage);
Remove (this is now done in the constructor) :-)

[lody, 2017-02-06 16:16:25]

https://codereview.chromium.org/2678033002/diff/1/ios/chrome/browser/ui/ntp/r...
File
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm
(right):

https://codereview.chromium.org/2678033002/diff/1/ios/chrome/browser/ui/ntp/r...
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:81:
std::string(kHTMLOfTestPage)}});
On 2017/02/06 15:54:36, sdefresne wrote:
> nit: can you put a comma after the first "}", i.e.
> "std::string(kHTMLOfTestPage)},});" (though clang-format will reformat this
once
> you introduce the comma :-)).

Done.

https://codereview.chromium.org/2678033002/diff/1/ios/chrome/browser/ui/ntp/r...
ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:82:
responses[testPageURL] = std::string(kHTMLOfTestPage);
On 2017/02/06 15:54:36, sdefresne wrote:
> Remove (this is now done in the constructor) :-)

Done.

[sdefresne, 2017-02-06 16:43:35]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-02-06 16:43:35]

lgtm

[commit-bot: I haz the power, 2017-02-06 16:43:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 17:09:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486399415397120,
"parent_rev": "6c29f74b23f0469aafc3aa8258245c4c08979409", "commit_rev":
"4a566253e6c5dc608fdc159696c67703318a1958"}

[commit-bot: I haz the power, 2017-02-06 17:10:21]

Description was changed from

==========
Refactoring recent tabs eg tests.

From comments in CL https://codereview.chromium.org/2677933003/

BUG=none
==========

to

==========
Refactoring recent tabs eg tests.

From comments in CL https://codereview.chromium.org/2677933003/

BUG=none

Review-Url: https://codereview.chromium.org/2678033002
Cr-Commit-Position: refs/heads/master@{#448278}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a566253e6c5dc608fdc159696c6...
==========

[commit-bot: I haz the power, 2017-02-06 17:10:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4a566253e6c5dc608fdc159696c6...