Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2677933003: [ObjC ARC] Converts ios/chrome/browser/ui/ntp/recent_tabs:eg_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
Reviewers:
stkhapugin, sdefresne
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/ntp/recent_tabs:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2677933003 Cr-Commit-Position: refs/heads/master@{#448259} Committed: https://chromium.googlesource.com/chromium/src/+/3da08bcd20a501948398e39977aa428d9df10d91

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm View 1 chunk +4 lines, -0 lines 3 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
lody
🐈 please review, thanks
3 years, 10 months ago (2017-02-06 15:13:50 UTC) #4
sdefresne
lgtm https://codereview.chromium.org/2677933003/diff/1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm File ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm (right): https://codereview.chromium.org/2677933003/diff/1/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm#newcode29 ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm:29: std::string const kHTMLOfTestPage = Could you remove this ...
3 years, 10 months ago (2017-02-06 15:24:58 UTC) #7
lody
I will address comments in a separate CL.
3 years, 10 months ago (2017-02-06 15:39:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677933003/1
3 years, 10 months ago (2017-02-06 15:39:36 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 15:44:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3da08bcd20a501948398e39977aa...

Powered by Google App Engine
This is Rietveld 408576698