ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm - Issue 2678033002: Refactoring recent tabs eg tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm

Issue 2678033002: Refactoring recent tabs eg tests. (Closed)

Patch Set: forgot to check build worked... Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm

diff --git a/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm b/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm

index 942e16974953bdae0f03e29496d902f7a43f2a70..f159fdd8a6890c1bd3fc1ceae5f803bcb67715b8 100644

--- a/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm

+++ b/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_panel_controller_egtest.mm

@@ -26,7 +26,7 @@

namespace {

const char kURLOfTestPage[] = "http://testPage";

-std::string const kHTMLOfTestPage =

+const char kHTMLOfTestPage[] =

"<head><title>TestPageTitle</title></head><body>hello</body>";

NSString* const kTitleOfTestPage = @"TestPageTitle";

@@ -76,10 +76,10 @@ id<GREYMatcher> RecentlyClosedLabelMatcher() {

- (void)setUp {

[ChromeEarlGrey clearBrowsingHistory];

[super setUp];

- std::map<GURL, std::string> responses;

- const GURL testPageURL = web::test::HttpServer::MakeUrl(kURLOfTestPage);

- responses[testPageURL] = kHTMLOfTestPage;

- web::test::SetUpSimpleHttpServer(responses);

+ web::test::SetUpSimpleHttpServer(std::map<GURL, std::string>{{

+ web::test::HttpServer::MakeUrl(kURLOfTestPage),

+ std::string(kHTMLOfTestPage),

+ }});

}

- (void)tearDown {

« no previous file with comments | « no previous file | no next file » | no next file with comments »