cc: Add color conversion support to all DrawQuad types

cc: Add color parameters for all quads

Rename GLRenderer::program_shadow_ to GLRenderer::current_program_,
and use this directly.

Change SetUseProgram to take a ProgramKey, and not a Program.

Specify a source color space to SetUseProgram. For the moment this is
largely ignored, but allow (except behind the video flag).

Update tests to build all shaders with color conversion enabled (not actually
testing the results yet, since the conversion mechanisms are in flux).

Add a RendererSettings::enable_color_correct_rendering flag, and plumb
that through with --enable-color-correct-rendering. With that command
line flag, all shaders will start using color conversion (though their inputs
will not be right).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2677893003
Cr-Commit-Position: refs/heads/master@{#449844}
Committed: https://chromium.googlesource.com/chromium/src/+/5d3f3e2d889382a65bc059b2f8f6d738b3643f46

[ccameron, 2017-02-06 20:35:44]

Description was changed from

==========
cc: Add color conversion support to all DrawQuad types

This allows any DrawQuad to enable color conversion by
- specifying the src and dst color space to the ProgramKey
- calling SetProgramColorConversionUniforms if the resulting program
  returns true for UsesColorConversionLUT

This patch also moves all YUV to RGB conversion into
gfx::ColorTransform::GetShaderSource. If no destination space is
specified to a cc::Program, then it will perform YUV to RGB conversion
only.

This does not add shader based color conversion for any other types,
because we only have test for YUV to RGB (so far).

BUG=667966
==========

to

==========
cc: Add color conversion support to all DrawQuad types

This allows any DrawQuad to enable color conversion by
- specifying the src and dst color space to the ProgramKey
- calling SetProgramColorConversionUniforms if the resulting program
  returns true for UsesColorConversionLUT

This patch also moves all YUV to RGB conversion into
gfx::ColorTransform::GetShaderSource. If no destination space is
specified to a cc::Program, then it will perform YUV to RGB conversion
only.

This does not add shader based color conversion for any other types,
because we only have test for YUV to RGB (so far).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-02-06 20:46:53]

ccameron@chromium.org changed reviewers:
+ hubbe@chromium.org

[ccameron, 2017-02-06 20:46:54]

This should make it reasonably straight-forward to add color conversion to other
DrawQuad types.

I didn't flesh out the generated conversion source any further than YUV to RGB
because that's all that we have test support for. When we add more support, I
think we should add tests which read the converted pixels back, and check that
they match the conversion done by the CPU-side gfx::ColorTransform.

[ccameron, 2017-02-10 19:26:46]

Description was changed from

==========
cc: Add color conversion support to all DrawQuad types

This allows any DrawQuad to enable color conversion by
- specifying the src and dst color space to the ProgramKey
- calling SetProgramColorConversionUniforms if the resulting program
  returns true for UsesColorConversionLUT

This patch also moves all YUV to RGB conversion into
gfx::ColorTransform::GetShaderSource. If no destination space is
specified to a cc::Program, then it will perform YUV to RGB conversion
only.

This does not add shader based color conversion for any other types,
because we only have test for YUV to RGB (so far).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add color parameters for all quads

Rename GLRenderer::program_shadow_ to GLRenderer::current_program_,
and use this directly.

Change SetUseProgram to take a ProgramKey, and not a Program.

Specify a source color space to SetUseProgram. For the moment this is
largely ignored, but allow (except for the experimental LUT-based video color
conversion).

Update tests to run all shaders with color conversion enabled (not actually
testing the results yet, since the conversion mechanisms are in flux).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-02-10 19:26:46]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org
- hubbe@chromium.org

[ccameron, 2017-02-10 19:29:09]

Description was changed from

==========
cc: Add color parameters for all quads

Rename GLRenderer::program_shadow_ to GLRenderer::current_program_,
and use this directly.

Change SetUseProgram to take a ProgramKey, and not a Program.

Specify a source color space to SetUseProgram. For the moment this is
largely ignored, but allow (except for the experimental LUT-based video color
conversion).

Update tests to run all shaders with color conversion enabled (not actually
testing the results yet, since the conversion mechanisms are in flux).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add color parameters for all quads

Rename GLRenderer::program_shadow_ to GLRenderer::current_program_,
and use this directly.

Change SetUseProgram to take a ProgramKey, and not a Program.

Specify a source color space to SetUseProgram. For the moment this is
largely ignored, but allow (except behind the video flag).

Update tests to build all shaders with color conversion enabled (not actually
testing the results yet, since the conversion mechanisms are in flux).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-02-10 19:34:17]

Description was changed from

==========
cc: Add color parameters for all quads

Rename GLRenderer::program_shadow_ to GLRenderer::current_program_,
and use this directly.

Change SetUseProgram to take a ProgramKey, and not a Program.

Specify a source color space to SetUseProgram. For the moment this is
largely ignored, but allow (except behind the video flag).

Update tests to build all shaders with color conversion enabled (not actually
testing the results yet, since the conversion mechanisms are in flux).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add color parameters for all quads

Rename GLRenderer::program_shadow_ to GLRenderer::current_program_,
and use this directly.

Change SetUseProgram to take a ProgramKey, and not a Program.

Specify a source color space to SetUseProgram. For the moment this is
largely ignored, but allow (except behind the video flag).

Update tests to build all shaders with color conversion enabled (not actually
testing the results yet, since the conversion mechanisms are in flux).

Add a RendererSettings::enable_color_correct_rendering flag, and plumb
that through with --enable-color-correct-rendering. With that command
line flag, all shaders will start using color conversion (though their inputs
will not be right).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-02-10 19:36:28]

ptal!

It draws color correct pixels (with not-really-correct input from Blink).

I'm also working on a set of tests to verify that the pixels produced by a color
transformed quad match the computations done by gfx::ColorTransform, but that
needs some orthogonal changes first.

[enne (OOO), 2017-02-10 22:40:42]

lgtm

https://codereview.chromium.org/2677893003/diff/40001/cc/output/gl_renderer.h
File cc/output/gl_renderer.h (right):

https://codereview.chromium.org/2677893003/diff/40001/cc/output/gl_renderer.h...
cc/output/gl_renderer.h:312: const Program* current_program_ = nullptr;
I considered suggesting this rename earlier...so thumbs up!

[ccameron, 2017-02-10 23:20:37]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 23:21:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 23:25:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 23:25:09]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ccameron, 2017-02-11 04:48:49]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-02-11 04:49:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 04:55:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486788529949090,
"parent_rev": "5237846c806ca677f5bca846e931dfa29428866b", "commit_rev":
"5d3f3e2d889382a65bc059b2f8f6d738b3643f46"}

[commit-bot: I haz the power, 2017-02-11 04:56:28]

Description was changed from

==========
cc: Add color parameters for all quads

Rename GLRenderer::program_shadow_ to GLRenderer::current_program_,
and use this directly.

Change SetUseProgram to take a ProgramKey, and not a Program.

Specify a source color space to SetUseProgram. For the moment this is
largely ignored, but allow (except behind the video flag).

Update tests to build all shaders with color conversion enabled (not actually
testing the results yet, since the conversion mechanisms are in flux).

Add a RendererSettings::enable_color_correct_rendering flag, and plumb
that through with --enable-color-correct-rendering. With that command
line flag, all shaders will start using color conversion (though their inputs
will not be right).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add color parameters for all quads

Rename GLRenderer::program_shadow_ to GLRenderer::current_program_,
and use this directly.

Change SetUseProgram to take a ProgramKey, and not a Program.

Specify a source color space to SetUseProgram. For the moment this is
largely ignored, but allow (except behind the video flag).

Update tests to build all shaders with color conversion enabled (not actually
testing the results yet, since the conversion mechanisms are in flux).

Add a RendererSettings::enable_color_correct_rendering flag, and plumb
that through with --enable-color-correct-rendering. With that command
line flag, all shaders will start using color conversion (though their inputs
will not be right).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2677893003
Cr-Commit-Position: refs/heads/master@{#449844}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d3f3e2d889382a65bc059b2f8f6...
==========

[commit-bot: I haz the power, 2017-02-11 04:56:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5d3f3e2d889382a65bc059b2f8f6...