Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2677263002: Remove unused parameter for -replaceTab:withTab:keepOldTabOpen:. (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused parameter for -replaceTab:withTab:keepOldTabOpen:. The sole caller of TabModel -replaceTab:withTab:keepOldTabOpen: is always passing NO for keepOldTabOpen value so remove the parameter. BUG=687207 Review-Url: https://codereview.chromium.org/2677263002 Cr-Commit-Position: refs/heads/master@{#448993} Committed: https://chromium.googlesource.com/chromium/src/+/e398e7fd334c08a2cfb805b25b0792fb15e674d3

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M ios/chrome/browser/tabs/tab_model.h View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 2 chunks +2 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
sdefresne
Please take a look.
3 years, 10 months ago (2017-02-06 16:41:15 UTC) #3
sdefresne
ping
3 years, 10 months ago (2017-02-07 16:20:47 UTC) #11
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-07 16:24:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677263002/40001
3 years, 10 months ago (2017-02-08 14:46:36 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 14:52:36 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e398e7fd334c08a2cfb805b25b07...

Powered by Google App Engine
This is Rietveld 408576698