Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 2674293002: Make certificate policy restoration thread-safe. (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make certificate policy restoration thread-safe. Use CancellableTaskTracker to make CleanCertificatePolicyCache thread-safe (i.e. nothing happens if the TabModel is deallocated while call to RestoreCertificatePolicyCacheFromModel is pending). BUG=687207 Review-Url: https://codereview.chromium.org/2674293002 Cr-Commit-Position: refs/heads/master@{#448990} Committed: https://chromium.googlesource.com/chromium/src/+/c92bada1c0623a5355817bfac78d7dc082119a8d

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -29 lines) Patch
M ios/chrome/browser/tabs/tab_model.mm View 9 chunks +39 lines, -29 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
sdefresne
Please take a look.
3 years, 10 months ago (2017-02-06 16:10:34 UTC) #2
sdefresne
ping
3 years, 10 months ago (2017-02-07 16:20:23 UTC) #11
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-08 14:03:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674293002/20001
3 years, 10 months ago (2017-02-08 14:32:13 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 14:44:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c92bada1c0623a5355817bfac78d...

Powered by Google App Engine
This is Rietveld 408576698