ios/chrome/browser/ui/browser_view_controller.mm - Issue 2677263002: Remove unused parameter for -replaceTab:withTab:keepOldTabOpen:.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2677263002: Remove unused parameter for -replaceTab:withTab:keepOldTabOpen:. (Closed)

Patch Set: Fix comment. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/browser_view_controller.mm

diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm

index 830c37820422ddaea14e7ed23db9deca4b86ee3a..d5238b394fdc49bfebb0cc48ccba83aa93ea9699 100644

--- a/ios/chrome/browser/ui/browser_view_controller.mm

+++ b/ios/chrome/browser/ui/browser_view_controller.mm

@@ -3683,7 +3683,7 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {

[newHistory insertStateFromSessionController:oldHistory];

[[newTab nativeAppNavigationController]

copyStateFrom:[oldTab nativeAppNavigationController]];

- [_model replaceTab:oldTab withTab:newTab keepOldTabOpen:NO];

+ [_model replaceTab:oldTab withTab:newTab];

// Set isPrerenderTab to NO after replacing the tab. This will allow the

// BrowserViewController to detect that a pre-rendered tab is switched in,

« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | no next file » | no next file with comments »