Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2677183003: Revert of PPC/s390: [debugger] remove debugger statement support from FCG/CS. (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of PPC/s390: [debugger] remove debugger statement support from FCG/CS. (patchset #1 id:1 of https://codereview.chromium.org/2672813002/ ) Reason for revert: Original CL got reverted https://codereview.chromium.org/2672823007 Original issue's description: > PPC/s390: [debugger] remove debugger statement support from FCG/CS. > > Port eef855a1dc956e9db03ec09abca1d732d379861b > > R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > LOG=N > > Review-Url: https://codereview.chromium.org/2672813002 > Cr-Commit-Position: refs/heads/master@{#42898} > Committed: https://chromium.googlesource.com/v8/v8/+/f2d2ebcae8f31a7787778c429018156a432662e2 TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2677183003 Cr-Commit-Position: refs/heads/master@{#42972} Committed: https://chromium.googlesource.com/v8/v8/+/8330952bf789b053fb4a1224e14c21cb56d5f9a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M src/ppc/macro-assembler-ppc.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
JaideepBajwa
Created Revert of PPC/s390: [debugger] remove debugger statement support from FCG/CS.
3 years, 10 months ago (2017-02-06 14:33:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677183003/1
3 years, 10 months ago (2017-02-06 14:33:44 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-06 14:33:46 UTC) #5
john.yan
lgtm
3 years, 10 months ago (2017-02-06 15:26:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677183003/1
3 years, 10 months ago (2017-02-06 16:06:21 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 16:28:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8330952bf789b053fb4a1224e14c21cb56d...

Powered by Google App Engine
This is Rietveld 408576698