Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2672813002: PPC/s390: [debugger] remove debugger statement support from FCG/CS. (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [debugger] remove debugger statement support from FCG/CS. Port eef855a1dc956e9db03ec09abca1d732d379861b R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2672813002 Cr-Commit-Position: refs/heads/master@{#42898} Committed: https://chromium.googlesource.com/v8/v8/+/f2d2ebcae8f31a7787778c429018156a432662e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -27 lines) Patch
M src/ppc/macro-assembler-ppc.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-02 16:12:14 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-02-02 17:38:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672813002/1
3 years, 10 months ago (2017-02-02 19:12:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/f2d2ebcae8f31a7787778c429018156a432662e2
3 years, 10 months ago (2017-02-02 19:33:32 UTC) #7
JaideepBajwa
3 years, 10 months ago (2017-02-06 14:33:40 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2677183003/ by bjaideep@ca.ibm.com.

The reason for reverting is: Original CL got reverted
https://codereview.chromium.org/2672823007.

Powered by Google App Engine
This is Rietveld 408576698