Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2672823007: Revert of [debugger] remove debugger statement support from FCG/CS. (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, Yang, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] remove debugger statement support from FCG/CS. (patchset #5 id:80001 of https://codereview.chromium.org/2650193002/ ) Reason for revert: Fails on chromium leak bot: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/2007 Original issue's description: > [debugger] remove debugger statement support from FCG/CS. > > > R=mstarzinger@chromium.org > > Review-Url: https://codereview.chromium.org/2650193002 > Cr-Commit-Position: refs/heads/master@{#42892} > Committed: https://chromium.googlesource.com/v8/v8/+/eef855a1dc956e9db03ec09abca1d732d379861b TBR=mstarzinger@chromium.org,yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2672823007 Cr-Commit-Position: refs/heads/master@{#42942} Committed: https://chromium.googlesource.com/v8/v8/+/7c79736019c9a0b9ef03f64ab26e46bb98692abf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -44 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/assembler.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/assembler.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/ast/ast.h View 1 chunk +20 lines, -4 lines 0 comments Download
M src/ast/ast-numbering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/debug/debug.cc View 5 chunks +12 lines, -3 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 3 chunks +11 lines, -20 lines 0 comments Download
M test/debugger/debug/debug-evaluate-closure.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/debugger/debug/debug-set-variable-value.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/debugger/debug/es6/debug-evaluate-blockscopes.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/debugger/debug/regress/regress-crbug-323936.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
kozy
Created Revert of [debugger] remove debugger statement support from FCG/CS.
3 years, 10 months ago (2017-02-04 17:34:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672823007/1
3 years, 10 months ago (2017-02-04 17:34:59 UTC) #3
kozy
To reproduce locally please build blink_tests with following flags: is_component_build = false is_debug = false ...
3 years, 10 months ago (2017-02-04 17:35:01 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 18:11:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7c79736019c9a0b9ef03f64ab26e46bb986...

Powered by Google App Engine
This is Rietveld 408576698