Chromium Code Reviews Chromium Code Reviews
Issue
2677023002:
Revert of Files app: Correct the order of file-list layer and empty-folder layer. (patchset #1 id:1… (Closed)
DescriptionRevert of Files app: Correct the order of file-list layer and empty-folder layer. (patchset #1 id:1 of https://codereview.chromium.org/2652413002/ )
Reason for revert:
This change causes a regression crbug.com/686618.
Original issue's description:
> Files app: Correct the order of file-list layer and empty-folder layer.
>
> The UI indicating that the folder is empty is behind the file-list layer.
> It used to be visible because the file-list has transparent background, but with
> https://codereview.chromium.org/2554433002, file-list got background color and
> the UI turned invisible.
> We should correct the order of layers instead of reverting the background color
> of file list, as the background color of file list is necessary to make use of
> native overlay scrollbar.
>
> BUG=685106
> TEST=manually tested
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2652413002
> Cr-Commit-Position: refs/heads/master@{#446280}
> Committed: https://chromium.googlesource.com/chromium/src/+/1d0085691a3932c3e299c4af35f71e6e97dc3222
TBR=yamaguchi@chromium.org
BUG=685106, 686618
Review-Url: https://codereview.chromium.org/2659313002
Cr-Commit-Position: refs/heads/master@{#446961}
(cherry picked from commit 8fbb4032d36b3ae10373db8d489a0f9276cc5d54)
Review-Url: https://codereview.chromium.org/2677023002 .
Cr-Commit-Position: refs/branch-heads/2987@{#317}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/c1836bb99563be3c67db606dbfacd5c719499a2e
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||
