Replace homebrew scrollbar in Files app with that of Blink.

Replace homebrew scrollbar in Files app with that of Blink.

When overlay scrollbar is enabled in Chrome, there is animation to shrink and fade out the scrollbar thumb when inactive. However, scroll bars that aren't composited will not be animated
(see Issue 671644). It would make the scroll bar always thick and simply disappear without fading out after inactive.
As a workaround, this change makes the 2 boxes have solid background and contain:paint so as to make sure the scrollers are composited.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fa7b28294ab9ee7e07569054d4e65626e2535f4e
Cr-Commit-Position: refs/heads/master@{#436868}

[yamaguchi, 2016-12-05 06:42:57]

Description was changed from

==========
Replace dedicated scrollbar and with that of Blink.

BUG=666589
==========

to

==========
Replace dedicated scrollbar and with that of Blink.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2016-12-05 06:43:05]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 06:43:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-12-05 06:44:05]

Description was changed from

==========
Replace dedicated scrollbar and with that of Blink.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Replace homebrew scrollbar in Files app with that of Blink.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2016-12-05 06:54:40]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 06:54:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 07:16:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 07:16:56]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2016-12-05 07:37:22]

yamaguchi@chromium.org changed reviewers:
+ fukino@chromium.org

[fukino, 2016-12-06 05:13:09]

https://codereview.chromium.org/2554433002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/2554433002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/css/file_manager.css:255: /* When
overlay scrollbar is enabled in Chrome, it will expand/collapse on
I'm still not sure why this is needed.
- What happens without this property?
- Could you elaborate in the bug description? (instead of a code comment?)
- If this is a workaround for an existing issue, could you add TODO comment with
crbug link?

https://codereview.chromium.org/2554433002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/css/file_manager.css:1112: overflow:
scroll !important;
I guess this is not necessary now.

[yamaguchi, 2016-12-07 02:35:47]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 02:36:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-12-07 02:37:24]

The CQ bit was checked by yamaguchi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 02:37:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2016-12-07 02:51:40]

Description was changed from

==========
Replace homebrew scrollbar in Files app with that of Blink.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Replace homebrew scrollbar in Files app with that of Blink.

When overlay scrollbar is enabled in Chrome, there is animation to shrink and
fade out the scrollbar thumb when inactive. However, scroll bars that aren't
composited will not be animated
(see Issue 671644). It would make the scroll bar always thick and simply
disappear without fading out after inactive.
As a workaround, this change makes the 2 boxes have solid background and
contain:paint so as to make sure the scrollers are composited.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yamaguchi, 2016-12-07 02:52:35]

https://codereview.chromium.org/2554433002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/css/file_manager.css (right):

https://codereview.chromium.org/2554433002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/css/file_manager.css:255: /* When
overlay scrollbar is enabled in Chrome, it will expand/collapse on
On 2016/12/06 05:13:09, fukino wrote:
> I'm still not sure why this is needed.
> - What happens without this property?
> - Could you elaborate in the bug description? (instead of a code comment?)
> - If this is a workaround for an existing issue, could you add TODO comment
with
> crbug link?

Done.

https://codereview.chromium.org/2554433002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/css/file_manager.css:1112: overflow:
scroll !important;
On 2016/12/06 05:13:09, fukino wrote:
> I guess this is not necessary now.

Done.

[commit-bot: I haz the power, 2016-12-07 03:05:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 03:05:19]

Dry run: This issue passed the CQ dry run.

[fukino, 2016-12-07 04:09:20]

lgtm

[yamaguchi, 2016-12-07 05:05:38]

The CQ bit was checked by yamaguchi@chromium.org

[commit-bot: I haz the power, 2016-12-07 05:05:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 05:10:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481087138189740,
"parent_rev": "b2aef7185d49c0dba185c2494760c71239017f49", "commit_rev":
"efca776d22b6a36165eebf0c436898a373b8b445"}

[commit-bot: I haz the power, 2016-12-07 05:11:13]

Description was changed from

==========
Replace homebrew scrollbar in Files app with that of Blink.

When overlay scrollbar is enabled in Chrome, there is animation to shrink and
fade out the scrollbar thumb when inactive. However, scroll bars that aren't
composited will not be animated
(see Issue 671644). It would make the scroll bar always thick and simply
disappear without fading out after inactive.
As a workaround, this change makes the 2 boxes have solid background and
contain:paint so as to make sure the scrollers are composited.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Replace homebrew scrollbar in Files app with that of Blink.

When overlay scrollbar is enabled in Chrome, there is animation to shrink and
fade out the scrollbar thumb when inactive. However, scroll bars that aren't
composited will not be animated
(see Issue 671644). It would make the scroll bar always thick and simply
disappear without fading out after inactive.
As a workaround, this change makes the 2 boxes have solid background and
contain:paint so as to make sure the scrollers are composited.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-07 05:11:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-07 05:14:33]

Description was changed from

==========
Replace homebrew scrollbar in Files app with that of Blink.

When overlay scrollbar is enabled in Chrome, there is animation to shrink and
fade out the scrollbar thumb when inactive. However, scroll bars that aren't
composited will not be animated
(see Issue 671644). It would make the scroll bar always thick and simply
disappear without fading out after inactive.
As a workaround, this change makes the 2 boxes have solid background and
contain:paint so as to make sure the scrollers are composited.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Replace homebrew scrollbar in Files app with that of Blink.

When overlay scrollbar is enabled in Chrome, there is animation to shrink and
fade out the scrollbar thumb when inactive. However, scroll bars that aren't
composited will not be animated
(see Issue 671644). It would make the scroll bar always thick and simply
disappear without fading out after inactive.
As a workaround, this change makes the 2 boxes have solid background and
contain:paint so as to make sure the scrollers are composited.

BUG=666589
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/fa7b28294ab9ee7e07569054d4e65626e2535f4e
Cr-Commit-Position: refs/heads/master@{#436868}
==========

[commit-bot: I haz the power, 2016-12-07 05:14:34]

Patchset 3 (id:??) landed as
https://crrev.com/fa7b28294ab9ee7e07569054d4e65626e2535f4e
Cr-Commit-Position: refs/heads/master@{#436868}

[yamaguchi, 2017-01-26 09:14:13]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2654873006/ by yamaguchi@chromium.org.

The reason for reverting is: Overlay scrollbar in Blink will be disabled on M57.
https://bugs.chromium.org/p/chromium/issues/detail?id=307091#c124
.