Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2659313002: Revert of Files app: Correct the order of file-list layer and empty-folder layer. (Closed)

Created:
3 years, 10 months ago by fukino
Modified:
3 years, 10 months ago
Reviewers:
yamaguchi
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Files app: Correct the order of file-list layer and empty-folder layer. (patchset #1 id:1 of https://codereview.chromium.org/2652413002/ ) Reason for revert: This change causes a regression crbug.com/686618. Original issue's description: > Files app: Correct the order of file-list layer and empty-folder layer. > > The UI indicating that the folder is empty is behind the file-list layer. > It used to be visible because the file-list has transparent background, but with > https://codereview.chromium.org/2554433002, file-list got background color and > the UI turned invisible. > We should correct the order of layers instead of reverting the background color > of file list, as the background color of file list is necessary to make use of > native overlay scrollbar. > > BUG=685106 > TEST=manually tested > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2652413002 > Cr-Commit-Position: refs/heads/master@{#446280} > Committed: https://chromium.googlesource.com/chromium/src/+/1d0085691a3932c3e299c4af35f71e6e97dc3222 TBR=yamaguchi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=685106, 686618 Review-Url: https://codereview.chromium.org/2659313002 Cr-Commit-Position: refs/heads/master@{#446961} Committed: https://chromium.googlesource.com/chromium/src/+/8fbb4032d36b3ae10373db8d489a0f9276cc5d54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/file_manager/file_manager/main.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
fukino
Created Revert of Files app: Correct the order of file-list layer and empty-folder layer.
3 years, 10 months ago (2017-01-30 06:32:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659313002/1
3 years, 10 months ago (2017-01-30 06:32:58 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 06:59:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8fbb4032d36b3ae10373db8d489a...

Powered by Google App Engine
This is Rietveld 408576698