Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2676653003:
[ObjC ARC] Converts ios/chrome/browser/ui/downloads:unit_tests to ARC. (Closed)
|
Created:
3 years, 10 months ago by stkhapugin Modified:
3 years, 8 months ago Reviewers:
noyau (Ping after 24h) CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[ObjC ARC] Converts ios/chrome/browser/ui/downloads:unit_tests to ARC.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Review-Url: https://codereview.chromium.org/2676653003
Cr-Commit-Position: refs/heads/master@{#464053}
Committed: https://chromium.googlesource.com/chromium/src/+/65c4eb23fd50e9e5199e8ab0fab8f652b69e277e
Patch Set 1 #
Total comments: 4
Patch Set 2 : comment #
Messages
Total messages: 18 (9 generated)
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stkhapugin@chromium.org changed reviewers: + noyau@chromium.org
ptal
https://codereview.chromium.org/2676653003/diff/1/ios/chrome/browser/ui/downl... File ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm (right): https://codereview.chromium.org/2676653003/diff/1/ios/chrome/browser/ui/downl... ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm:87: DownloadManagerController* _controller; Same here, I'm becoming more uncomfortable changing those for C++ classes. Maybe we should require "strong" here?
https://codereview.chromium.org/2676653003/diff/1/ios/chrome/browser/ui/downl... File ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm (right): https://codereview.chromium.org/2676653003/diff/1/ios/chrome/browser/ui/downl... ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm:87: DownloadManagerController* _controller; On 2017/02/03 12:57:48, noyau wrote: > Same here, I'm becoming more uncomfortable changing those for C++ classes. Maybe > we should require "strong" here? This is a private unit test-only class in an implementation file, it cannot be included from elsewhere, there is no risk having ARC managing these.
ping
https://codereview.chromium.org/2676653003/diff/1/ios/chrome/browser/ui/downl... File ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm (right): https://codereview.chromium.org/2676653003/diff/1/ios/chrome/browser/ui/downl... ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm:87: DownloadManagerController* _controller; On 2017/02/03 13:05:57, stkhapugin wrote: > On 2017/02/03 12:57:48, noyau wrote: > > Same here, I'm becoming more uncomfortable changing those for C++ classes. > Maybe > > we should require "strong" here? > > This is a private unit test-only class in an implementation file, it cannot be > included from elsewhere, there is no risk having ARC managing these. Sorry for the delay. These need strong as discussed.
PTAL https://codereview.chromium.org/2676653003/diff/1/ios/chrome/browser/ui/downl... File ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm (right): https://codereview.chromium.org/2676653003/diff/1/ios/chrome/browser/ui/downl... ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm:87: DownloadManagerController* _controller; On 2017/03/17 13:26:01, noyau wrote: > On 2017/02/03 13:05:57, stkhapugin wrote: > > On 2017/02/03 12:57:48, noyau wrote: > > > Same here, I'm becoming more uncomfortable changing those for C++ classes. > > Maybe > > > we should require "strong" here? > > > > This is a private unit test-only class in an implementation file, it cannot be > > included from elsewhere, there is no risk having ARC managing these. > > Sorry for the delay. These need strong as discussed. Done.
lgtm
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492008517669820,
"parent_rev": "fe3f46f92f93b06b429c51439cbb846d42c0521f", "commit_rev":
"65c4eb23fd50e9e5199e8ab0fab8f652b69e277e"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492008517669820,
"parent_rev": "fe3f46f92f93b06b429c51439cbb846d42c0521f", "commit_rev":
"65c4eb23fd50e9e5199e8ab0fab8f652b69e277e"}
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/ui/downloads:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/ui/downloads:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2676653003 Cr-Commit-Position: refs/heads/master@{#464053} Committed: https://chromium.googlesource.com/chromium/src/+/65c4eb23fd50e9e5199e8ab0fab8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/65c4eb23fd50e9e5199e8ab0fab8... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
