[ObjC ARC] Converts ios/chrome/browser/ui/downloads:unit_tests to ARC.

ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/downloads/download_manager_controller.h"
 
 #import <UIKit/UIKit.h>
 
 #include <memory>
 
-#import "base/mac/scoped_nsobject.h"
 #include "base/message_loop/message_loop.h"
 #import "ios/chrome/browser/storekit_launcher.h"
 #include "ios/web/public/test/test_web_thread.h"
 #include "net/base/net_errors.h"
 #include "net/http/http_response_headers.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest_mac.h"
 #include "testing/platform_test.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 using net::HttpResponseHeaders;
 using net::URLRequestStatus;
 
 @interface DownloadManagerController (ExposedForTesting)
 - (UIView*)documentContainer;
 - (UIView*)progressBar;
 - (UIImageView*)documentIcon;
 - (UIImageView*)foldIcon;
 - (UILabel*)timeLeftLabel;
 - (UILabel*)fileTypeLabel;
@@ skipping 28 matching lines @@
 
  protected:
   void SetUp() override {
     PlatformTest::SetUp();
 
     _request_context_getter =
         new net::TestURLRequestContextGetter(_message_loop.task_runner());
 
     _fetcher_factory.reset(new net::TestURLFetcherFactory());
 
-    _store_kit_launcher.reset([[TestStoreKitLauncher alloc] init]);
+    _store_kit_launcher = [[TestStoreKitLauncher alloc] init];
 
-    _controller.reset([[DownloadManagerController alloc]
+    _controller = [[DownloadManagerController alloc]
                  initWithURL:kTestURL
         requestContextGetter:_request_context_getter.get()
-            storeKitLauncher:_store_kit_launcher.get()]);
+            storeKitLauncher:_store_kit_launcher];
   }
 
   base::MessageLoop _message_loop;
   web::TestWebThread _ui_thread;
-  base::scoped_nsobject<TestStoreKitLauncher> _store_kit_launcher;
+  TestStoreKitLauncher* _store_kit_launcher;
   scoped_refptr<net::TestURLRequestContextGetter> _request_context_getter;
   std::unique_ptr<net::TestURLFetcherFactory> _fetcher_factory;
-  base::scoped_nsobject<DownloadManagerController> _controller;
+  DownloadManagerController* _controller;

[noyau (Ping after 24h), 2017/02/03 12:57:48]

Same here, I'm becoming more uncomfortable changing those for C++ classes. Maybe
we should require "strong" here?

[stkhapugin, 2017/02/03 13:05:57]

This is a private unit test-only class in an implementation file, it cannot be
included from elsewhere, there is no risk having ARC managing these. 

[noyau (Ping after 24h), 2017/03/17 13:26:01]

Sorry for the delay. These need strong as discussed.

[stkhapugin, 2017/04/11 15:55:15]

Done.

 };
 
 TEST_F(DownloadManagerControllerTest, TestXibViewConnections) {
   EXPECT_TRUE([_controller documentContainer]);
   EXPECT_TRUE([_controller progressBar]);
   EXPECT_TRUE([_controller documentIcon]);
   EXPECT_TRUE([_controller foldIcon]);
   EXPECT_TRUE([_controller timeLeftLabel]);
   EXPECT_TRUE([_controller fileTypeLabel]);
   EXPECT_TRUE([_controller fileNameLabel]);
@@ skipping 51 matching lines @@
   EXPECT_FALSE(
       [[UIApplication sharedApplication] isNetworkActivityIndicatorVisible]);
 
   EXPECT_TRUE([_controller fileTypeLabel].hidden);
   EXPECT_FALSE([_controller downloadButton].hidden);
   EXPECT_FALSE([_controller errorIcon].hidden);
   EXPECT_FALSE([_controller errorOrSizeLabel].hidden);
 }
 
 }  // namespace