Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm

Issue 2676653003: [ObjC ARC] Converts ios/chrome/browser/ui/downloads:unit_tests to ARC. (Closed)
Patch Set: comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/downloads/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm b/ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm
index d816a0b1afb96906ca72bfae43f0d5ff97eb9ef2..f0c35abba3e6e79c5afaeae442ceee904396d2af 100644
--- a/ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm
+++ b/ios/chrome/browser/ui/downloads/download_manager_controller_unittest.mm
@@ -8,7 +8,6 @@
#include <memory>
-#import "base/mac/scoped_nsobject.h"
#include "base/message_loop/message_loop.h"
#import "ios/chrome/browser/store_kit/store_kit_launcher.h"
#import "ios/chrome/browser/store_kit/store_kit_tab_helper.h"
@@ -23,6 +22,10 @@
#include "testing/platform_test.h"
#import "third_party/ocmock/OCMock/OCMock.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
using net::HttpResponseHeaders;
using net::URLRequestStatus;
@@ -58,13 +61,12 @@ class DownloadManagerControllerTest : public ChromeWebTest {
id mock_launcher =
[OCMockObject niceMockForProtocol:@protocol(StoreKitLauncher)];
helper->SetLauncher(mock_launcher);
- _controller.reset([[DownloadManagerController alloc]
- initWithWebState:web_state()
- downloadURL:kTestURL]);
+ _controller =
+ [[DownloadManagerController alloc] initWithWebState:web_state()
+ downloadURL:kTestURL];
}
-
std::unique_ptr<net::TestURLFetcherFactory> _fetcher_factory;
- base::scoped_nsobject<DownloadManagerController> _controller;
+ __strong DownloadManagerController* _controller;
};
TEST_F(DownloadManagerControllerTest, TestXibViewConnections) {
« no previous file with comments | « ios/chrome/browser/ui/downloads/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698