Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2676343002: Revert of [Autofill] Use user's email for converted wallet addresses. (Closed)

Created:
3 years, 10 months ago by sebsg
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert of [Autofill] Use user's email for converted wallet addresses. (patchset #1 id:1 of https://codereview.chromium.org/2671423002/ ) Reason for revert: Breakage on Clank Original issue's description: > [Autofill] Use user's email for converted wallet addresses. > > Since Wallet addresses don't have an email address, the signed-in > user's email address should be used if the Wallet address is not > merged into an existing local profile. > > BUG=680182 > > Review-Url: https://codereview.chromium.org/2671813005 > Cr-Commit-Position: refs/heads/master@{#448008} > (cherry picked from commit c853dbe32cdd2b2a6699593fe8e06879568bc6db) > > Review-Url: https://codereview.chromium.org/2671423002 . > Cr-Commit-Position: refs/branch-heads/2987@{#326} > Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} > Committed: https://chromium.googlesource.com/chromium/src/+/c36552b1dfa02ee19dc9f1bf8c80bc75d5323b1b TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=680182 Review-Url: https://codereview.chromium.org/2676343002 Cr-Commit-Position: refs/branch-heads/2987@{#329} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f68dab39cd8b9748e3b70c2ba32ba1df6d26438d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sebsg
Created Revert of [Autofill] Use user's email for converted wallet addresses.
3 years, 10 months ago (2017-02-06 16:31:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676343002/1
3 years, 10 months ago (2017-02-06 16:32:32 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 16:35:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f68dab39cd8b9748e3b70c2ba32b...

Powered by Google App Engine
This is Rietveld 408576698