[Autofill] Use user's email for converted wallet addresses.

[Autofill] Use user's email for converted wallet addresses.

Since Wallet addresses don't have an email address, the signed-in
user's email address should be used if the Wallet address is not
merged into an existing local profile.

BUG=680182
Review-Url: https://codereview.chromium.org/2671813005
Cr-Commit-Position: refs/heads/master@{#448008}
Committed: https://chromium.googlesource.com/chromium/src/+/c853dbe32cdd2b2a6699593fe8e06879568bc6db

[sebsg, 2017-02-03 15:16:55]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 15:17:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-02-03 15:18:24]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[sebsg, 2017-02-03 15:18:33]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-03 15:18:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-02-03 15:18:54]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2017-02-03 15:18:54]

Hi Math, PTAL?

[Mathieu, 2017-02-03 15:27:22]

lgtm

https://codereview.chromium.org/2671813005/diff/20001/components/autofill/cor...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/2671813005/diff/20001/components/autofill/cor...
components/autofill/core/browser/personal_data_manager.cc:1926:
base::UTF8ToUTF16(account_tracker_->GetAccountInfo(account_id).email);
this is sometimes empty. Let's add 

if (!email.empty())
 ...

[sebsg, 2017-02-03 15:39:52]

Sending to CQ thanks!

https://codereview.chromium.org/2671813005/diff/20001/components/autofill/cor...
File components/autofill/core/browser/personal_data_manager.cc (right):

https://codereview.chromium.org/2671813005/diff/20001/components/autofill/cor...
components/autofill/core/browser/personal_data_manager.cc:1926:
base::UTF8ToUTF16(account_tracker_->GetAccountInfo(account_id).email);
On 2017/02/03 15:27:22, Mathieu Perreault wrote:
> this is sometimes empty. Let's add 
> 
> if (!email.empty())
>  ...

Done.

[sebsg, 2017-02-03 15:39:54]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-02-03 15:39:55]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2671813005/#ps40001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-02-03 15:40:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 16:46:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486136394901780,
"parent_rev": "792b8e63f3a6f5d5b1f3621fe0816ddbf2f6b57e", "commit_rev":
"c853dbe32cdd2b2a6699593fe8e06879568bc6db"}

[commit-bot: I haz the power, 2017-02-03 16:46:47]

Description was changed from

==========
[Autofill] Use user's email for converted wallet addresses.

Since Wallet addresses don't have an email address, the signed-in
user's email address should be used if the Wallet address is not
merged into an existing local profile.

BUG=680182
==========

to

==========
[Autofill] Use user's email for converted wallet addresses.

Since Wallet addresses don't have an email address, the signed-in
user's email address should be used if the Wallet address is not
merged into an existing local profile.

BUG=680182

Review-Url: https://codereview.chromium.org/2671813005
Cr-Commit-Position: refs/heads/master@{#448008}
Committed:
https://chromium.googlesource.com/chromium/src/+/c853dbe32cdd2b2a6699593fe8e0...
==========

[commit-bot: I haz the power, 2017-02-03 16:46:48]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c853dbe32cdd2b2a6699593fe8e0...