Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2671813005: [Autofill] Use user's email for converted wallet addresses. (Closed)

Created:
3 years, 10 months ago by sebsg
Modified:
3 years, 10 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Use user's email for converted wallet addresses. Since Wallet addresses don't have an email address, the signed-in user's email address should be used if the Wallet address is not merged into an existing local profile. BUG=680182 Review-Url: https://codereview.chromium.org/2671813005 Cr-Commit-Position: refs/heads/master@{#448008} Committed: https://chromium.googlesource.com/chromium/src/+/c853dbe32cdd2b2a6699593fe8e06879568bc6db

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M components/autofill/core/browser/personal_data_manager.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sebsg
Hi Math, PTAL?
3 years, 10 months ago (2017-02-03 15:18:54 UTC) #7
Mathieu
lgtm https://codereview.chromium.org/2671813005/diff/20001/components/autofill/core/browser/personal_data_manager.cc File components/autofill/core/browser/personal_data_manager.cc (right): https://codereview.chromium.org/2671813005/diff/20001/components/autofill/core/browser/personal_data_manager.cc#newcode1926 components/autofill/core/browser/personal_data_manager.cc:1926: base::UTF8ToUTF16(account_tracker_->GetAccountInfo(account_id).email); this is sometimes empty. Let's add if ...
3 years, 10 months ago (2017-02-03 15:27:22 UTC) #8
sebsg
Sending to CQ thanks! https://codereview.chromium.org/2671813005/diff/20001/components/autofill/core/browser/personal_data_manager.cc File components/autofill/core/browser/personal_data_manager.cc (right): https://codereview.chromium.org/2671813005/diff/20001/components/autofill/core/browser/personal_data_manager.cc#newcode1926 components/autofill/core/browser/personal_data_manager.cc:1926: base::UTF8ToUTF16(account_tracker_->GetAccountInfo(account_id).email); On 2017/02/03 15:27:22, Mathieu ...
3 years, 10 months ago (2017-02-03 15:39:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671813005/40001
3 years, 10 months ago (2017-02-03 15:40:12 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 16:46:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c853dbe32cdd2b2a6699593fe8e0...

Powered by Google App Engine
This is Rietveld 408576698