Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2671423002: [Autofill] Use user's email for converted wallet addresses. (Closed)

Created:
3 years, 10 months ago by sebsg
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Autofill] Use user's email for converted wallet addresses. Since Wallet addresses don't have an email address, the signed-in user's email address should be used if the Wallet address is not merged into an existing local profile. BUG=680182 Review-Url: https://codereview.chromium.org/2671813005 Cr-Commit-Position: refs/heads/master@{#448008} (cherry picked from commit c853dbe32cdd2b2a6699593fe8e06879568bc6db) Review-Url: https://codereview.chromium.org/2671423002 . Cr-Commit-Position: refs/branch-heads/2987@{#326} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/c36552b1dfa02ee19dc9f1bf8c80bc75d5323b1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sebsg
Committed patchset #1 (id:1) manually as c36552b1dfa02ee19dc9f1bf8c80bc75d5323b1b.
3 years, 10 months ago (2017-02-06 15:29:34 UTC) #2
sebsg
3 years, 10 months ago (2017-02-06 16:31:31 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2676343002/ by sebsg@chromium.org.

The reason for reverting is: Breakage on Clank.

Powered by Google App Engine
This is Rietveld 408576698