cros: Fold UserBoardModel into UserSelectionScreen.

cros: Fold UserBoardModel into UserSelectionScreen.

BUG=672142
Review-Url: https://codereview.chromium.org/2676323003
Cr-Commit-Position: refs/heads/master@{#448893}
Committed: https://chromium.googlesource.com/chromium/src/+/76f6120183c45c90cb9e37ea12ec963d858e2dad

[jdufault, 2017-02-06 22:36:06]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 22:36:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 00:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 00:08:39]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-02-07 00:15:22]

https://codereview.chromium.org/2676323003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/user_selection_screen.h (right):

https://codereview.chromium.org/2676323003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_selection_screen.h:119:
LoginDisplayWebUIHandler* handler_ = nullptr;
I believe handler_ and login_display_delegate_ can be moved to the private
section; I'll do so in the next patch.

[jdufault, 2017-02-07 00:15:34]

Description was changed from

==========
cros: Fold UserBoardModel into UserSelectionScreen.

BUG=672142
==========

to

==========
cros: Fold UserBoardModel into UserSelectionScreen.

BUG=672142
==========

[jdufault, 2017-02-07 00:15:34]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2017-02-07 00:15:47]

achuith@ PTAL. Thanks!

[achuithb, 2017-02-07 00:28:43]

lgtm

https://codereview.chromium.org/2676323003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/user_selection_screen.h (right):

https://codereview.chromium.org/2676323003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_selection_screen.h:119:
LoginDisplayWebUIHandler* handler_ = nullptr;
On 2017/02/07 00:15:22, jdufault wrote:
> I believe handler_ and login_display_delegate_ can be moved to the private
> section; I'll do so in the next patch.

Acknowledged.

https://codereview.chromium.org/2676323003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_selection_screen.h:124: typedef
std::map<AccountId, std::vector<std::string> >
Also switch to using since you're here?

[jdufault, 2017-02-08 00:58:34]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-02-08 00:58:34]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2676323003/#ps20001
(title: "Address comments")

[jdufault, 2017-02-08 00:58:42]

https://codereview.chromium.org/2676323003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/user_selection_screen.h (right):

https://codereview.chromium.org/2676323003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_selection_screen.h:124: typedef
std::map<AccountId, std::vector<std::string> >
On 2017/02/07 00:28:43, achuithb wrote:
> Also switch to using since you're here?

Done.

[commit-bot: I haz the power, 2017-02-08 00:59:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 03:29:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486515514194320,
"parent_rev": "5903317ed90e3203ce2ead7a9ddda5ef0429b0d2", "commit_rev":
"76f6120183c45c90cb9e37ea12ec963d858e2dad"}

[commit-bot: I haz the power, 2017-02-08 03:29:38]

Description was changed from

==========
cros: Fold UserBoardModel into UserSelectionScreen.

BUG=672142
==========

to

==========
cros: Fold UserBoardModel into UserSelectionScreen.

BUG=672142

Review-Url: https://codereview.chromium.org/2676323003
Cr-Commit-Position: refs/heads/master@{#448893}
Committed:
https://chromium.googlesource.com/chromium/src/+/76f6120183c45c90cb9e37ea12ec...
==========

[commit-bot: I haz the power, 2017-02-08 03:29:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76f6120183c45c90cb9e37ea12ec...