cros: Fold UserImageModel into UserImageScreen

cros: Fold UserImageModel into UserImageScreen

BUG=672142
Review-Url: https://codereview.chromium.org/2684883002
Cr-Commit-Position: refs/heads/master@{#449754}
Committed: https://chromium.googlesource.com/chromium/src/+/75ab22d721451fbe895843e588ef66558ba03ddb

[jdufault, 2017-02-08 02:26:41]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 02:27:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 03:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 03:45:55]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-02-08 18:26:18]

Description was changed from

==========
cros: Fold UserImageModel into UserImageScreen

BUG=672142
==========

to

==========
cros: Fold UserImageModel into UserImageScreen

BUG=672142
==========

[jdufault, 2017-02-08 18:26:19]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2017-02-08 18:26:33]

achuith@ PTAL. Thanks

[achuithb, 2017-02-08 20:05:56]

lgtm

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/user_image_screen.h (right):

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_image_screen.h:59: // Called when
user accepts currently selected image
nit period

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_image_screen.h:62: // Called when
actor is destroyed so there's no dead reference to it.
Don't use 'actor' here?

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_image_screen.h:142:
std::unique_ptr<base::Timer> sync_timer_;
Move this to next to sync_waiting_start_time_?

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h (right):

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h:20: // WebUI
implementation of UserImageScreenActor. It is used to interact
There's no more UserImageScreenActor, right?

[jdufault, 2017-02-10 20:32:15]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-02-10 20:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2684883002/#ps20001
(title: "Address comments")

[jdufault, 2017-02-10 20:32:23]

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/user_image_screen.h (right):

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_image_screen.h:59: // Called when
user accepts currently selected image
On 2017/02/08 20:05:56, achuithb wrote:
> nit period

Done.

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_image_screen.h:62: // Called when
actor is destroyed so there's no dead reference to it.
On 2017/02/08 20:05:56, achuithb wrote:
> Don't use 'actor' here?

Done.

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/user_image_screen.h:142:
std::unique_ptr<base::Timer> sync_timer_;
On 2017/02/08 20:05:56, achuithb wrote:
> Move this to next to sync_waiting_start_time_?

Done.

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h (right):

https://codereview.chromium.org/2684883002/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h:20: // WebUI
implementation of UserImageScreenActor. It is used to interact
On 2017/02/08 20:05:56, achuithb wrote:
> There's no more UserImageScreenActor, right?

Done.

[commit-bot: I haz the power, 2017-02-10 20:33:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 22:13:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486758735728610,
"parent_rev": "c010a4d03a91256d1b514fae3d710acffe46db30", "commit_rev":
"75ab22d721451fbe895843e588ef66558ba03ddb"}

[commit-bot: I haz the power, 2017-02-10 22:13:43]

Description was changed from

==========
cros: Fold UserImageModel into UserImageScreen

BUG=672142
==========

to

==========
cros: Fold UserImageModel into UserImageScreen

BUG=672142

Review-Url: https://codereview.chromium.org/2684883002
Cr-Commit-Position: refs/heads/master@{#449754}
Committed:
https://chromium.googlesource.com/chromium/src/+/75ab22d721451fbe895843e588ef...
==========

[commit-bot: I haz the power, 2017-02-10 22:13:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/75ab22d721451fbe895843e588ef...