cros: Fold UserBoardModel into UserSelectionScreen.

chrome/browser/chromeos/login/screens/user_selection_screen.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_USER_SELECTION_SCREEN_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_USER_SELECTION_SCREEN_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/timer/timer.h"
 #include "base/values.h"
+#include "chrome/browser/chromeos/login/screens/base_screen.h"
 #include "chrome/browser/chromeos/login/signin/token_handle_util.h"
 #include "chrome/browser/chromeos/login/ui/login_display.h"
-#include "chrome/browser/chromeos/login/ui/models/user_board_model.h"
 #include "components/proximity_auth/screenlock_bridge.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "components/user_manager/user.h"
 #include "ui/base/user_activity/user_activity_observer.h"
 
 class AccountId;
 class EasyUnlockService;
 
 namespace chromeos {
 
 class LoginDisplayWebUIHandler;
 class UserBoardView;
 
 // This class represents User Selection screen: user pod-based login screen.
 class UserSelectionScreen
     : public ui::UserActivityObserver,
       public proximity_auth::ScreenlockBridge::LockHandler,
-      public UserBoardModel {
+      public BaseScreen {
  public:
   explicit UserSelectionScreen(const std::string& display_type);
   ~UserSelectionScreen() override;
 
   void SetLoginDisplayDelegate(LoginDisplay::Delegate* login_display_delegate);
   void SetHandler(LoginDisplayWebUIHandler* handler);
   void SetView(UserBoardView* view);
 
   static const user_manager::UserList PrepareUserListForSending(
       const user_manager::UserList& users,
       const AccountId& owner,
       bool is_signin_to_add);
 
   virtual void Init(const user_manager::UserList& users, bool show_guest);
   void OnUserImageChanged(const user_manager::User& user);
   void OnBeforeUserRemoved(const AccountId& account_id);
   void OnUserRemoved(const AccountId& account_id);
 
   void OnPasswordClearTimerExpired();
 
   void HandleGetUsers();
   void CheckUserStatus(const AccountId& account_id);
 
+  // Build list of users and send it to the webui.
+  virtual void SendUserList();
+
+  // Methods for easy unlock support.
+  void HardLockPod(const AccountId& account_id);
+  void AttemptEasyUnlock(const AccountId& account_id);
+  void RecordClickOnLockIcon(const AccountId& account_id);
+
   // ui::UserActivityDetector implementation:
   void OnUserActivity(const ui::Event* event) override;
 
   void InitEasyUnlock();
 
   // proximity_auth::ScreenlockBridge::LockHandler implementation:
   void ShowBannerMessage(const base::string16& message) override;
   void ShowUserPodCustomIcon(
       const AccountId& account_id,
       const proximity_auth::ScreenlockBridge::UserPodCustomIconOptions& icon)
       override;
   void HideUserPodCustomIcon(const AccountId& account_id) override;
 
   void EnableInput() override;
   void SetAuthType(const AccountId& account_id,
                    AuthType auth_type,
                    const base::string16& auth_value) override;
   AuthType GetAuthType(const AccountId& account_id) const override;
   ScreenType GetScreenType() const override;
 
   void Unlock(const AccountId& account_id) override;
   void AttemptEasySignin(const AccountId& account_id,
                          const std::string& secret,
                          const std::string& key_label) override;
 
-  // UserBoardModel implementation.
-  void SendUserList() override;
-  void HardLockPod(const AccountId& account_id) override;
-  void AttemptEasyUnlock(const AccountId& account_id) override;
-  void RecordClickOnLockIcon(const AccountId& account_id) override;
+  // BaseScreen implementation:
+  void Show() override;
+  void Hide() override;
 
   // Fills |user_dict| with information about |user|.
   static void FillUserDictionary(
       user_manager::User* user,
       bool is_owner,
       bool is_signin_to_add,
       AuthType auth_type,
       const std::vector<std::string>* public_session_recommended_locales,
       base::DictionaryValue* user_dict);
 
   // Fills |user_dict| with |user| known preferences.
   static void FillKnownUserPrefs(user_manager::User* user,
                                  base::DictionaryValue* user_dict);
 
   // Fills |user_dict| with |user| multi-profile related preferences.
   static void FillMultiProfileUserPrefs(user_manager::User* user,
                                         base::DictionaryValue* user_dict,
                                         bool is_signin_to_add);
 
   // Determines if user auth status requires online sign in.
   static bool ShouldForceOnlineSignIn(const user_manager::User* user);
 
  protected:
-  LoginDisplayWebUIHandler* handler_;
-  LoginDisplay::Delegate* login_display_delegate_;
-  UserBoardView* view_;
+  LoginDisplayWebUIHandler* handler_ = nullptr;

[jdufault, 2017/02/07 00:15:22]

I believe handler_ and login_display_delegate_ can be moved to the private
section; I'll do so in the next patch.

[achuithb, 2017/02/07 00:28:42]

Acknowledged.

+  LoginDisplay::Delegate* login_display_delegate_ = nullptr;
+  UserBoardView* view_ = nullptr;
 
   // Map from public session account IDs to recommended locales set by policy.
   typedef std::map<AccountId, std::vector<std::string> >

[achuithb, 2017/02/07 00:28:43]

Also switch to using since you're here?

[jdufault, 2017/02/08 00:58:42]

Done.

       PublicSessionRecommendedLocaleMap;
   PublicSessionRecommendedLocaleMap public_session_recommended_locales_;
 
  private:
   EasyUnlockService* GetEasyUnlockServiceForUser(
       const AccountId& account_id) const;
 
   void OnUserStatusChecked(const AccountId& account_id,
                            TokenHandleUtil::TokenHandleStatus status);
 
   // Whether to show guest login.
-  bool show_guest_;
+  bool show_guest_ = false;
 
   // Purpose of the screen (see constants in OobeUI).
   const std::string display_type_;
 
   // Set of Users that are visible.
   user_manager::UserList users_;
 
   // Map of accounnt ids to their current authentication type. If a user is not
   // contained in the map, it is using the default authentication type.
   std::map<AccountId, proximity_auth::ScreenlockBridge::LockHandler::AuthType>
       user_auth_type_map_;
 
   // Timer for measuring idle state duration before password clear.
   base::OneShotTimer password_clear_timer_;
 
   // Token handler util for checking user OAuth token status.
   std::unique_ptr<TokenHandleUtil> token_handle_util_;
 
   base::WeakPtrFactory<UserSelectionScreen> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(UserSelectionScreen);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_USER_SELECTION_SCREEN_H_