Leave immersive bar header layers as opaque.

Leave immersive bar header layers as opaque.

They are already opaque anyway, so this doesn't create any visible
change.

BUG=none

Review-Url: https://codereview.chromium.org/2674813002
Cr-Commit-Position: refs/heads/master@{#448065}
Committed: https://chromium.googlesource.com/chromium/src/+/8262cc428a027ec4fbe8f9ba86c5f7a99895a357

[Evan Stade, 2017-02-03 03:28:09]

estade@chromium.org changed reviewers:
+ jamescook@chromium.org, pkotwicz@chromium.org

[Evan Stade, 2017-02-03 03:28:10]

originally changed here (3 years ago): https://codereview.chromium.org/176523002

The immersive mode header for apps is no longer partially transparent. In light
of this, we don't need a non-opaque layer. However, perhaps this is an
unintended regression?

I don't understand why the change was made for normal browser windows in the
first place. This was discussed in the above patch, and I can see how it might
not have caused issues. Yet I also don't understand the need for it,.

Context: I want to change this because
a) it improves performance
b) it's tripping a subpixel rendering check I'm trying to add.

[pkotwicz, 2017-02-03 04:26:01]

LGTM

[pkotwicz, 2017-02-03 04:31:09]

The reason that I had to modify both header_view.cc and
immersive_mode_controller_ash.cc is to handle the two types of apps on CrOS:
packaged apps and hosted apps.

[James Cook, 2017-02-03 18:29:39]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2017-02-03 18:29:39]

LGTM but +sky as FYI since he's been working on immersive fullscreen for mustash

I'm not sure if apps are supposed to have transparent header on reveal or not.

[Evan Stade, 2017-02-03 18:35:44]

On 2017/02/03 04:31:09, pkotwicz wrote:
> The reason that I had to modify both header_view.cc and
> immersive_mode_controller_ash.cc is to handle the two types of apps on CrOS:
> packaged apps and hosted apps.

ah, makes sense. Thanks.

[Evan Stade, 2017-02-03 18:35:47]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-02-03 18:36:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 20:46:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486146947777510, "parent_rev":
"5d75c709a85d920def3968d00c95542801eb7bd4", "commit_rev":
"8262cc428a027ec4fbe8f9ba86c5f7a99895a357"}

[commit-bot: I haz the power, 2017-02-03 20:47:05]

Description was changed from

==========
Leave immersive bar header layers as opaque.

They are already opaque anyway, so this doesn't create any visible
change.

BUG=none
==========

to

==========
Leave immersive bar header layers as opaque.

They are already opaque anyway, so this doesn't create any visible
change.

BUG=none

Review-Url: https://codereview.chromium.org/2674813002
Cr-Commit-Position: refs/heads/master@{#448065}
Committed:
https://chromium.googlesource.com/chromium/src/+/8262cc428a027ec4fbe8f9ba86c5...
==========

[commit-bot: I haz the power, 2017-02-03 20:47:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8262cc428a027ec4fbe8f9ba86c5...