Make the top bar semitransparent when in immersive fullscreen

Make the top bar semitransparent when in immersive fullscreen

BUG=346062
TEST=Manual, see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253977

[pkotwicz, 2014-02-23 03:17:20]

James, PTAL

[James Cook, 2014-02-24 17:40:06]

https://codereview.chromium.org/176523002/diff/1/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc (right):

https://codereview.chromium.org/176523002/diff/1/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc:171:
browser_view_->top_container()->SetFillsBoundsOpaquely(false);
So the top container for *all* immersive fullscreen reveals is now going to be
transparent?  Does that look OK for the typical browser window case with opaque
tabs?

[pkotwicz, 2014-02-27 19:26:51]

James, can you please take another look?

https://codereview.chromium.org/176523002/diff/1/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc (right):

https://codereview.chromium.org/176523002/diff/1/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc:171:
browser_view_->top_container()->SetFillsBoundsOpaquely(false);
This merely disables some of the optimizations that we do if the contents of a
layer are fully opaque. This does not actually set the opacity of a layer.
Immersive reveals for browser windows will look exactly the same because because
we use fully opaque image assets to paint the top container.

[James Cook, 2014-02-27 20:46:12]

lgtm

[pkotwicz, 2014-02-27 20:52:48]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-27 20:53:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/176523002/1

[commit-bot: I haz the power, 2014-02-27 23:51:01]

Change committed as 253977