Revert: Change CaptureSynchronizer and PointerWatcherEventRouter to support multiple CaptureClients

Revert of Change CaptureSynchronizer and PointerWatcherEventRouter to support multiple CaptureClients. (patchset #9 id:240001 of https://codereview.chromium.org/2626013005/ )

Reason for revert:
Caused aura_unittests
WindowTreeClientClientTest.TwoWindowTreesRequestCapture
to fail consistently on

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/19320

since LSan detects a leak:

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x52fcfb in operator new(unsigned long) (/b/s/w/irdxqiGi/out/Release/aura_unittests+0x52fcfb)
    #1 0x729983 in aura::WindowTreeClientClientTest_TwoWindowTreesRequestCapture_Test::TestBody() ui/aura/mus/window_tree_client_unittest.cc:1376:7

Original issue's description:
> Change CaptureSynchronizer and PointerWatcherEventRouter to support 
> multiple CaptureClients.
> 
> DesktopNativeWidgetAura was using DesktopCaptureClient but 
> CaptureSynchronizer was only supporting one CaptureClient, which is
> a CaptureController. Therefore made the following changes:
> 
> 1. We have one CaptureController for ash and multiple 
> DesktopCaptureClients for all mus clients. This CL changes 
> CaptureSynchronizer and PointerWatcherEventRouter to support multiple 
> CaptureClients. When a root window's capture client is set, MusClient
> will be notified by DesktopWindowTreeHostMus if it's a 
> DesktopCaptureClient, and WindowManager will take care of 
> CaptureController. We then add CaptureSynchronizer and 
> PointerWatcherEventRouter to be the observer for that CaptureClient.
> 
> 2. Update DesktopCaptureClient to notify its observers when capture
> has changed. 
> 
> BUG=676002, 678057
> TEST=aura_unittests views_mus_unittests
> 
> Review-Url: https://codereview.chromium.org/2626013005
> Cr-Commit-Position: refs/heads/master@{#447621}
> Committed: https://chromium.googlesource.com/chromium/src/+/e75f053a801b6a6322a57a9417582f14ebc3f161

TBR=sadrul@chromium.org,sky@chromium.org,riajiang@chromium.org
# Not skipping CQ checks since other patches may depend on this one:
# - https://codereview.chromium.org/2667073002
# - https://codereview.chromium.org/2657873006
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=676002, 678057

[johnme, 2017-02-02 12:59:20]

The CQ bit was checked by johnme@chromium.org

[johnme, 2017-02-02 12:59:20]

Created Revert of Change CaptureSynchronizer and PointerWatcherEventRouter to
support multiple CaptureClients.

[johnme, 2017-02-02 13:00:38]

The CQ bit was unchecked by johnme@chromium.org

[commit-bot: I haz the power, 2017-02-02 13:00:47]

Description was changed from

==========
Revert of Change CaptureSynchronizer and PointerWatcherEventRouter to support
multiple CaptureClients. (patchset #9 id:240001 of
https://codereview.chromium.org/2626013005/ )

Reason for revert:
Caused aura_unittests
WindowTreeClientClientTest.TwoWindowTreesRequestCapture
to fail consistently on

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

since LSan detects a leak:

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x52fcfb in operator new(unsigned long)
(/b/s/w/irdxqiGi/out/Release/aura_unittests+0x52fcfb)
    #1 0x729983 in
aura::WindowTreeClientClientTest_TwoWindowTreesRequestCapture_Test::TestBody()
ui/aura/mus/window_tree_client_unittest.cc:1376:7

Original issue's description:
> Change CaptureSynchronizer and PointerWatcherEventRouter to support 
> multiple CaptureClients.
> 
> DesktopNativeWidgetAura was using DesktopCaptureClient but 
> CaptureSynchronizer was only supporting one CaptureClient, which is
> a CaptureController. Therefore made the following changes:
> 
> 1. We have one CaptureController for ash and multiple 
> DesktopCaptureClients for all mus clients. This CL changes 
> CaptureSynchronizer and PointerWatcherEventRouter to support multiple 
> CaptureClients. When a root window's capture client is set, MusClient
> will be notified by DesktopWindowTreeHostMus if it's a 
> DesktopCaptureClient, and WindowManager will take care of 
> CaptureController. We then add CaptureSynchronizer and 
> PointerWatcherEventRouter to be the observer for that CaptureClient.
> 
> 2. Update DesktopCaptureClient to notify its observers when capture
> has changed. 
> 
> BUG=676002, 678057
> TEST=aura_unittests views_mus_unittests
> 
> Review-Url: https://codereview.chromium.org/2626013005
> Cr-Commit-Position: refs/heads/master@{#447621}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e75f053a801b6a6322a57a941758...

TBR=sadrul@chromium.org,sky@chromium.org,riajiang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=676002, 678057
==========

to

==========
Revert of Change CaptureSynchronizer and PointerWatcherEventRouter to support
multiple CaptureClients. (patchset #9 id:240001 of
https://codereview.chromium.org/2626013005/ )

Reason for revert:
Caused aura_unittests
WindowTreeClientClientTest.TwoWindowTreesRequestCapture
to fail consistently on

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

since LSan detects a leak:

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x52fcfb in operator new(unsigned long)
(/b/s/w/irdxqiGi/out/Release/aura_unittests+0x52fcfb)
    #1 0x729983 in
aura::WindowTreeClientClientTest_TwoWindowTreesRequestCapture_Test::TestBody()
ui/aura/mus/window_tree_client_unittest.cc:1376:7

Original issue's description:
> Change CaptureSynchronizer and PointerWatcherEventRouter to support 
> multiple CaptureClients.
> 
> DesktopNativeWidgetAura was using DesktopCaptureClient but 
> CaptureSynchronizer was only supporting one CaptureClient, which is
> a CaptureController. Therefore made the following changes:
> 
> 1. We have one CaptureController for ash and multiple 
> DesktopCaptureClients for all mus clients. This CL changes 
> CaptureSynchronizer and PointerWatcherEventRouter to support multiple 
> CaptureClients. When a root window's capture client is set, MusClient
> will be notified by DesktopWindowTreeHostMus if it's a 
> DesktopCaptureClient, and WindowManager will take care of 
> CaptureController. We then add CaptureSynchronizer and 
> PointerWatcherEventRouter to be the observer for that CaptureClient.
> 
> 2. Update DesktopCaptureClient to notify its observers when capture
> has changed. 
> 
> BUG=676002, 678057
> TEST=aura_unittests views_mus_unittests
> 
> Review-Url: https://codereview.chromium.org/2626013005
> Cr-Commit-Position: refs/heads/master@{#447621}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e75f053a801b6a6322a57a941758...

TBR=sadrul@chromium.org,sky@chromium.org,riajiang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=676002, 678057

Review-Url: https://codereview.chromium.org/2674683002
Cr-Commit-Position: refs/heads/master@{#447753}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5a30c08e753738a71894ed1f43c...
==========

[johnme, 2017-02-02 13:03:02]

Description was changed from

==========
Revert of Change CaptureSynchronizer and PointerWatcherEventRouter to support
multiple CaptureClients. (patchset #9 id:240001 of
https://codereview.chromium.org/2626013005/ )

Reason for revert:
Caused aura_unittests
WindowTreeClientClientTest.TwoWindowTreesRequestCapture
to fail consistently on

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

since LSan detects a leak:

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x52fcfb in operator new(unsigned long)
(/b/s/w/irdxqiGi/out/Release/aura_unittests+0x52fcfb)
    #1 0x729983 in
aura::WindowTreeClientClientTest_TwoWindowTreesRequestCapture_Test::TestBody()
ui/aura/mus/window_tree_client_unittest.cc:1376:7

Original issue's description:
> Change CaptureSynchronizer and PointerWatcherEventRouter to support 
> multiple CaptureClients.
> 
> DesktopNativeWidgetAura was using DesktopCaptureClient but 
> CaptureSynchronizer was only supporting one CaptureClient, which is
> a CaptureController. Therefore made the following changes:
> 
> 1. We have one CaptureController for ash and multiple 
> DesktopCaptureClients for all mus clients. This CL changes 
> CaptureSynchronizer and PointerWatcherEventRouter to support multiple 
> CaptureClients. When a root window's capture client is set, MusClient
> will be notified by DesktopWindowTreeHostMus if it's a 
> DesktopCaptureClient, and WindowManager will take care of 
> CaptureController. We then add CaptureSynchronizer and 
> PointerWatcherEventRouter to be the observer for that CaptureClient.
> 
> 2. Update DesktopCaptureClient to notify its observers when capture
> has changed. 
> 
> BUG=676002, 678057
> TEST=aura_unittests views_mus_unittests
> 
> Review-Url: https://codereview.chromium.org/2626013005
> Cr-Commit-Position: refs/heads/master@{#447621}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e75f053a801b6a6322a57a941758...

TBR=sadrul@chromium.org,sky@chromium.org,riajiang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=676002, 678057

Review-Url: https://codereview.chromium.org/2674683002
Cr-Commit-Position: refs/heads/master@{#447753}
Committed:
https://chromium.googlesource.com/chromium/src/+/f5a30c08e753738a71894ed1f43c...
==========

to

==========
Revert of Change CaptureSynchronizer and PointerWatcherEventRouter to support
multiple CaptureClients. (patchset #9 id:240001 of
https://codereview.chromium.org/2626013005/ )

Reason for revert:
Caused aura_unittests
WindowTreeClientClientTest.TwoWindowTreesRequestCapture
to fail consistently on

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2...

since LSan detects a leak:

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x52fcfb in operator new(unsigned long)
(/b/s/w/irdxqiGi/out/Release/aura_unittests+0x52fcfb)
    #1 0x729983 in
aura::WindowTreeClientClientTest_TwoWindowTreesRequestCapture_Test::TestBody()
ui/aura/mus/window_tree_client_unittest.cc:1376:7

Original issue's description:
> Change CaptureSynchronizer and PointerWatcherEventRouter to support 
> multiple CaptureClients.
> 
> DesktopNativeWidgetAura was using DesktopCaptureClient but 
> CaptureSynchronizer was only supporting one CaptureClient, which is
> a CaptureController. Therefore made the following changes:
> 
> 1. We have one CaptureController for ash and multiple 
> DesktopCaptureClients for all mus clients. This CL changes 
> CaptureSynchronizer and PointerWatcherEventRouter to support multiple 
> CaptureClients. When a root window's capture client is set, MusClient
> will be notified by DesktopWindowTreeHostMus if it's a 
> DesktopCaptureClient, and WindowManager will take care of 
> CaptureController. We then add CaptureSynchronizer and 
> PointerWatcherEventRouter to be the observer for that CaptureClient.
> 
> 2. Update DesktopCaptureClient to notify its observers when capture
> has changed. 
> 
> BUG=676002, 678057
> TEST=aura_unittests views_mus_unittests
> 
> Review-Url: https://codereview.chromium.org/2626013005
> Cr-Commit-Position: refs/heads/master@{#447621}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e75f053a801b6a6322a57a941758...

TBR=sadrul@chromium.org,sky@chromium.org,riajiang@chromium.org
# Not skipping CQ checks since other patches may depend on this one:
# - https://codereview.chromium.org/2667073002
# - https://codereview.chromium.org/2657873006
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=676002, 678057
==========

[johnme, 2017-02-02 13:03:07]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2017-02-02 13:03:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 13:04:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 13:04:46]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[findit-for-me, 2017-02-02 13:20:11]

FYI: Findit identified this CL at revision 447753 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[johnme, 2017-02-02 13:23:39]

I'm confused - I cancelled the CQ, removed the NOTRY=true, then re-enabled CQ.
As you can see, the description here doesn't have NOTRY, and there's no
auto-generated comment from the CQ saying it landed. However it clearly did land
as https://crrev.com/f5a30c08e753738a71894ed1f43c07a6d0421dc6, so I'll close
this. It also broke compile, since it turns out
https://codereview.chromium.org/2657873006 did depend on this. I've created a
revert of that patchset in https://codereview.chromium.org/2669203002 which
should hopefully fix the compile failure.