Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2669203002: Revert: Remove WindowTreeClientDelegate::GetCaptureClient() and WindowTreeClient::GetCaptureClient() (Closed)

Created:
3 years, 10 months ago by johnme
Modified:
3 years, 10 months ago
CC:
chromium-reviews, kalyank, rjkroege, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove WindowTreeClientDelegate::GetCaptureClient() and WindowTreeClient::GetCaptureClient(). (patchset #3 id:40001 of https://codereview.chromium.org/2657873006/ ) Reason for revert: Prevents reverting https://codereview.chromium.org/2674683002 Original issue's description: > Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and > WindowTreeClient::GetCaptureClient(). > > This CL is separated out from https://codereview.chromium.org/2626013005 > > BUG=676002, 678057 > > Review-Url: https://codereview.chromium.org/2657873006 > Cr-Commit-Position: refs/heads/master@{#447680} > Committed: https://chromium.googlesource.com/chromium/src/+/6c8ec587ec4cf305eafb23d136dd4a34fd825730 TBR=rockot@chromium.org,sadrul@chromium.org,sky@chromium.org,riajiang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=676002, 678057 Review-Url: https://codereview.chromium.org/2669203002 Cr-Commit-Position: refs/heads/master@{#447755} Committed: https://chromium.googlesource.com/chromium/src/+/7c809220a7efcf0c26793f7357ad7e69f2804638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M ash/mus/window_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/window_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/mus/window_manager_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mash/simple_wm/simple_wm.h View 1 chunk +1 line, -0 lines 0 comments Download
M mash/simple_wm/simple_wm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M services/navigation/view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/navigation/view_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M services/ui/demo/mus_demo.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M services/ui/test_wm/test_wm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/ws/window_server_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_server_test_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client_delegate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/mus/mus_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/mus_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
johnme
Created Revert of Remove WindowTreeClientDelegate::GetCaptureClient() and WindowTreeClient::GetCaptureClient().
3 years, 10 months ago (2017-02-02 13:18:21 UTC) #2
johnme
3 years, 10 months ago (2017-02-02 13:25:47 UTC) #4
Message was sent while issue was closed.
This landed as https://crrev.com/7c809220a7efcf0c26793f7357ad7e69f2804638

Powered by Google App Engine
This is Rietveld 408576698