Remove WindowTreeClientDelegate::GetCaptureClient() and WindowTreeClient::GetCaptureClient().

Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=676002, 678057
Review-Url: https://codereview.chromium.org/2657873006
Cr-Original-Commit-Position: refs/heads/master@{#447680}
Committed: https://chromium.googlesource.com/chromium/src/+/6c8ec587ec4cf305eafb23d136dd4a34fd825730
Review-Url: https://codereview.chromium.org/2657873006
Cr-Commit-Position: refs/heads/master@{#447843}
Committed: https://chromium.googlesource.com/chromium/src/+/f1238c589d9d22d51fe24c0744e28389e594267f

[riajiang, 2017-01-26 21:47:43]

Description was changed from

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=none
==========

to

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=none
==========

[riajiang, 2017-01-26 23:00:45]

riajiang@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2017-01-27 01:15:13]

Thanks! lgtm

https://codereview.chromium.org/2657873006/diff/1/ui/views/mus/mus_client.cc
File ui/views/mus/mus_client.cc (right):

https://codereview.chromium.org/2657873006/diff/1/ui/views/mus/mus_client.cc#...
ui/views/mus/mus_client.cc:34: #include "ui/wm/core/capture_controller.h"
Probably no longer needed?

[riajiang, 2017-01-27 19:39:44]

riajiang@chromium.org changed reviewers:
+ rockot@chromium.org, sky@chromium.org

[riajiang, 2017-01-27 19:39:44]

Hi, sky@ could you take a look at ash/, mash/ and services/ui? rockot@ could you
take a look at services/navigation? Thank you!

[sky, 2017-01-27 20:14:35]

https://codereview.chromium.org/2657873006/diff/1/ui/aura/mus/window_tree_cli...
File ui/aura/mus/window_tree_client.cc (right):

https://codereview.chromium.org/2657873006/diff/1/ui/aura/mus/window_tree_cli...
ui/aura/mus/window_tree_client.cc:467:
base::MakeUnique<CaptureSynchronizer>(this, tree_, GetCaptureClient());
Isn't GetCaptureClient() used here?

[riajiang, 2017-01-27 20:23:21]

https://codereview.chromium.org/2657873006/diff/1/ui/aura/mus/window_tree_cli...
File ui/aura/mus/window_tree_client.cc (right):

https://codereview.chromium.org/2657873006/diff/1/ui/aura/mus/window_tree_cli...
ui/aura/mus/window_tree_client.cc:467:
base::MakeUnique<CaptureSynchronizer>(this, tree_, GetCaptureClient());
On 2017/01/27 20:14:35, sky wrote:
> Isn't GetCaptureClient() used here?

Yes this CL is dependent on https://codereview.chromium.org/2626013005/ which
will remove all use cases of GetCaptureClient(). Separated this part out into
this CL.

[Ken Rockot(use gerrit already), 2017-01-27 20:23:54]

navigation rs lgtm

[sky, 2017-01-27 20:27:12]

Ok, LGTM then

[riajiang, 2017-02-01 22:15:08]

The CQ bit was checked by riajiang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 22:15:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[riajiang, 2017-02-01 22:24:02]

Description was changed from

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=none
==========

to

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=676002, 678057
==========

[commit-bot: I haz the power, 2017-02-01 23:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 23:20:17]

Dry run: This issue passed the CQ dry run.

[riajiang, 2017-02-01 23:20:36]

The CQ bit was checked by riajiang@chromium.org

[riajiang, 2017-02-01 23:20:36]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
sadrul@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2657873006/#ps20001
(title: "remove include")

[commit-bot: I haz the power, 2017-02-01 23:21:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 23:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 23:25:53]

Failed to apply patch for ui/aura/mus/window_tree_client.h:
While running git apply --index -p1;
  error: patch failed: ui/aura/mus/window_tree_client.h:115
  error: ui/aura/mus/window_tree_client.h: patch does not apply

Patch:       ui/aura/mus/window_tree_client.h
Index: ui/aura/mus/window_tree_client.h
diff --git a/ui/aura/mus/window_tree_client.h b/ui/aura/mus/window_tree_client.h
index
6144da49f7f2e76a73bf83ef634abc10ce190dee..81bebb8e8db22ad9e4a5d12e3ee5d95d4a4e3b91
100644
--- a/ui/aura/mus/window_tree_client.h
+++ b/ui/aura/mus/window_tree_client.h
@@ -68,10 +68,6 @@ class WindowTreeClientObserver;
 class WindowTreeClientTestObserver;
 class WindowTreeHostMus;
 
-namespace client {
-class CaptureClient;
-}
-
 using EventResultCallback = base::Callback<void(ui::mojom::EventResult)>;
 
 // Manages the connection with mus.
@@ -115,8 +111,6 @@ class AURA_EXPORT WindowTreeClient
   bool connected() const { return tree_ != nullptr; }
   ClientSpecificId client_id() const { return client_id_; }
 
-  client::CaptureClient* GetCaptureClient();
-
   void SetCanFocus(Window* window, bool can_focus);
   void SetCanAcceptDrops(Id window_id, bool can_accept_drops);
   void SetCanAcceptEvents(WindowMus* window, bool can_accept_events);

[riajiang, 2017-02-01 23:37:01]

The CQ bit was checked by riajiang@chromium.org

[riajiang, 2017-02-01 23:37:02]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
sadrul@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2657873006/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-01 23:37:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 01:50:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485992221980410,
"parent_rev": "bc9a6161faa2b8261a38df8f0d640cb42a7e26d0", "commit_rev":
"6c8ec587ec4cf305eafb23d136dd4a34fd825730"}

[commit-bot: I haz the power, 2017-02-02 01:51:18]

Description was changed from

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=676002, 678057
==========

to

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=676002, 678057

Review-Url: https://codereview.chromium.org/2657873006
Cr-Commit-Position: refs/heads/master@{#447680}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c8ec587ec4cf305eafb23d136dd...
==========

[commit-bot: I haz the power, 2017-02-02 01:51:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6c8ec587ec4cf305eafb23d136dd...

[johnme, 2017-02-02 13:18:21]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2669203002/ by johnme@chromium.org.

The reason for reverting is: Prevents reverting
https://codereview.chromium.org/2674683002.

[riajiang, 2017-02-02 16:35:56]

Description was changed from

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=676002, 678057

Review-Url: https://codereview.chromium.org/2657873006
Cr-Commit-Position: refs/heads/master@{#447680}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c8ec587ec4cf305eafb23d136dd...
==========

to

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=676002, 678057

Review-Url: https://codereview.chromium.org/2657873006
Cr-Commit-Position: refs/heads/master@{#447680}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c8ec587ec4cf305eafb23d136dd...
==========

[riajiang, 2017-02-02 21:12:33]

The CQ bit was checked by riajiang@chromium.org

[commit-bot: I haz the power, 2017-02-02 21:12:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 21:23:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486069953652970,
"parent_rev": "5c10efaf05bdde8188c305283ae207071674c0fd", "commit_rev":
"f1238c589d9d22d51fe24c0744e28389e594267f"}

[commit-bot: I haz the power, 2017-02-02 21:24:07]

Description was changed from

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=676002, 678057

Review-Url: https://codereview.chromium.org/2657873006
Cr-Commit-Position: refs/heads/master@{#447680}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c8ec587ec4cf305eafb23d136dd...
==========

to

==========
Remove virtual function WindowTreeClientDelegate::GetCaptureClient() and
WindowTreeClient::GetCaptureClient().

This CL is separated out from https://codereview.chromium.org/2626013005

BUG=676002, 678057

Review-Url: https://codereview.chromium.org/2657873006
Cr-Original-Commit-Position: refs/heads/master@{#447680}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c8ec587ec4cf305eafb23d136dd...
Review-Url: https://codereview.chromium.org/2657873006
Cr-Commit-Position: refs/heads/master@{#447843}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1238c589d9d22d51fe24c0744e2...
==========

[commit-bot: I haz the power, 2017-02-02 21:24:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f1238c589d9d22d51fe24c0744e2...