This is a merge to beta. There were two test expectation files that conflicted (console/console-format.html, ...
3 years, 10 months ago
(2017-02-06 17:25:36 UTC)
#2
This is a merge to beta. There were two test expectation files that conflicted
(console/console-format.html, console/console-format-es6.html). I checked out a
commit close to beta, cherry picked, and reset their results.
This requires a committer's l g t m, ptal!
pfeldman
lgtm
3 years, 10 months ago
(2017-02-06 18:13:12 UTC)
#3
lgtm
luoe
The CQ bit was checked by luoe@chromium.org
3 years, 10 months ago
(2017-02-06 18:13:36 UTC)
#4
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago
(2017-02-06 18:13:59 UTC)
#7
CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them
luoe
Description was changed from ========== DevTools: restore the style of expandable titles on console object ...
3 years, 10 months ago
(2017-02-06 18:25:50 UTC)
#8
Description was changed from
==========
DevTools: restore the style of expandable titles on console object previews
This CL reverts changes to the rendering of console objects. The goal is to
restore clarity to the fact that text shown to the right of the arrow is a stale
snapshot while items in the tree expansion are computed live once on expand.
Expanded titles will just show the 'i' note, instead of an abbreviated title:
https://codereview.chromium.org/2139043002
Italic titles will be restored, once removed in:
https://codereview.chromium.org/2514123003
BUG=688137
Review-Url: https://codereview.chromium.org/2676773002
Cr-Commit-Position: refs/heads/master@{#447934}
(cherry picked from commit 9d8e815220afc20f198f0b513cb46edc2d823186)
==========
to
==========
DevTools: restore the style of expandable titles on console object previews
This CL reverts changes to the rendering of console objects. The goal is to
restore clarity to the fact that text shown to the right of the arrow is a stale
snapshot while items in the tree expansion are computed live once on expand.
Expanded titles will just show the 'i' note, instead of an abbreviated title:
https://codereview.chromium.org/2139043002
Italic titles will be restored, once removed in:
https://codereview.chromium.org/2514123003
BUG=688137
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2676773002
Cr-Commit-Position: refs/heads/master@{#447934}
(cherry picked from commit 9d8e815220afc20f198f0b513cb46edc2d823186)
==========
luoe
The CQ bit was checked by luoe@chromium.org
3 years, 10 months ago
(2017-02-06 18:25:58 UTC)
#9
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1486405558501900, "parent_rev": "738b5637aa3218e44f5a29ea9412a69efc26e2a3", "commit_rev": "9b8accd71b9931b2e71fca9b0b823e381872ebb5"}
3 years, 10 months ago
(2017-02-06 18:29:18 UTC)
#11
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486405558501900, "parent_rev":
"738b5637aa3218e44f5a29ea9412a69efc26e2a3", "commit_rev":
"9b8accd71b9931b2e71fca9b0b823e381872ebb5"}
commit-bot: I haz the power
Description was changed from ========== DevTools: restore the style of expandable titles on console object ...
3 years, 10 months ago
(2017-02-06 18:29:58 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
DevTools: restore the style of expandable titles on console object previews
This CL reverts changes to the rendering of console objects. The goal is to
restore clarity to the fact that text shown to the right of the arrow is a stale
snapshot while items in the tree expansion are computed live once on expand.
Expanded titles will just show the 'i' note, instead of an abbreviated title:
https://codereview.chromium.org/2139043002
Italic titles will be restored, once removed in:
https://codereview.chromium.org/2514123003
BUG=688137
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2676773002
Cr-Commit-Position: refs/heads/master@{#447934}
(cherry picked from commit 9d8e815220afc20f198f0b513cb46edc2d823186)
==========
to
==========
DevTools: restore the style of expandable titles on console object previews
This CL reverts changes to the rendering of console objects. The goal is to
restore clarity to the fact that text shown to the right of the arrow is a stale
snapshot while items in the tree expansion are computed live once on expand.
Expanded titles will just show the 'i' note, instead of an abbreviated title:
https://codereview.chromium.org/2139043002
Italic titles will be restored, once removed in:
https://codereview.chromium.org/2514123003
BUG=688137
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2676773002
Cr-Commit-Position: refs/heads/master@{#447934}
(cherry picked from commit 9d8e815220afc20f198f0b513cb46edc2d823186)
Review-Url: https://codereview.chromium.org/2674243004
Cr-Commit-Position: refs/branch-heads/2987@{#335}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b8accd71b9931b2e71fca9b0b82...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9b8accd71b9931b2e71fca9b0b823e381872ebb5
3 years, 10 months ago
(2017-02-06 18:29:58 UTC)
#13
Issue 2674243004: DevTools: restore the style of expandable titles on console object previews
(Closed)
Created 3 years, 10 months ago by luoe
Modified 3 years, 10 months ago
Reviewers: pfeldman, kozy
Base URL:
Comments: 0