Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2676773002: DevTools: restore the style of expandable titles on console object previews (Closed)

Created:
3 years, 10 months ago by luoe
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: restore the style of expandable titles on console object previews This CL reverts changes to the rendering of console objects. The goal is to restore clarity to the fact that text shown to the right of the arrow is a stale snapshot while items in the tree expansion are computed live once on expand. Expanded titles will just show the 'i' note, instead of an abbreviated title: https://codereview.chromium.org/2139043002 Italic titles will be restored, once removed in: https://codereview.chromium.org/2514123003 BUG=688137 Review-Url: https://codereview.chromium.org/2676773002 Cr-Commit-Position: refs/heads/master@{#447934} Committed: https://chromium.googlesource.com/chromium/src/+/9d8e815220afc20f198f0b513cb46edc2d823186

Patch Set 1 #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -221 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-call-getter-on-proto-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-edit-property-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-broken-unicode.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2-expected.txt View 16 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt View 2 chunks +35 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt View 16 chunks +81 lines, -77 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt View 1 chunk +36 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-uncaught-promise-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/worker-eval-contains-stack-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 4 chunks +5 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
luoe
Please take a look
3 years, 10 months ago (2017-02-03 02:06:03 UTC) #4
pfeldman
lgtm
3 years, 10 months ago (2017-02-03 02:38:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676773002/20001
3 years, 10 months ago (2017-02-03 04:25:16 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:31:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d8e815220afc20f198f0b513cb4...

Powered by Google App Engine
This is Rietveld 408576698