Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2514123003: DevTools: non-italic previews that always wrap (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: non-italic previews that always wrap Title previews should never go off screen, but wrap as needed and be styled in non-italics. For example, console.log(document.all) does not wrap. Screenshot: http://imgur.com/a/ZDN7d BUG=405845, 668922 Committed: https://crrev.com/c991b760877ff12b2ae886ca6d04922a099e1806 Cr-Commit-Position: refs/heads/master@{#433660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/consoleView.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
luoe
Please see section C4 in the doc.
4 years, 1 month ago (2016-11-19 00:51:31 UTC) #3
lushnikov
lgtm
4 years, 1 month ago (2016-11-21 19:03:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514123003/1
4 years, 1 month ago (2016-11-21 21:41:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 21:47:20 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 21:48:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c991b760877ff12b2ae886ca6d04922a099e1806
Cr-Commit-Position: refs/heads/master@{#433660}

Powered by Google App Engine
This is Rietveld 408576698