Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2673993003: [Predator] Pass config as argument to findit. (Closed)

Created:
3 years, 10 months ago by Sharu Jiang
Modified:
3 years, 10 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org, lijeffrey, inferno
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : Fix nits. #

Patch Set 4 : Rebase. #

Patch Set 5 : Fix pylint. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -144 lines) Patch
M appengine/findit/crash/crash_pipeline.py View 4 chunks +6 lines, -4 lines 0 comments Download
M appengine/findit/crash/findit.py View 1 2 7 chunks +30 lines, -6 lines 0 comments Download
M appengine/findit/crash/findit_for_chromecrash.py View 1 2 6 chunks +7 lines, -24 lines 0 comments Download
M appengine/findit/crash/test/findit_for_chromecrash_test.py View 1 2 11 chunks +37 lines, -30 lines 0 comments Download
M appengine/findit/crash/test/findit_test.py View 4 chunks +18 lines, -14 lines 0 comments Download
M appengine/findit/handlers/crash/crash_handler.py View 2 chunks +4 lines, -2 lines 0 comments Download
M appengine/findit/handlers/crash/test/crash_handler_test.py View 4 chunks +6 lines, -39 lines 0 comments Download
M appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py View 1 2 3 4 2 chunks +18 lines, -25 lines 0 comments Download

Messages

Total messages: 26 (15 generated)
Sharu Jiang
3 years, 10 months ago (2017-02-03 23:09:03 UTC) #3
chanli
lgtm with a nit https://codereview.chromium.org/2673993003/diff/1/appengine/findit/crash/findit.py File appengine/findit/crash/findit.py (right): https://codereview.chromium.org/2673993003/diff/1/appengine/findit/crash/findit.py#newcode45 appengine/findit/crash/findit.py:45: for ``GitilesRepository``). nit: add docstring ...
3 years, 10 months ago (2017-02-03 23:58:51 UTC) #4
lijeffrey
lgtm
3 years, 10 months ago (2017-02-06 21:35:34 UTC) #6
wrengr (wrong one)
lgtm
3 years, 10 months ago (2017-02-10 21:58:08 UTC) #8
Sharu Jiang
https://codereview.chromium.org/2673993003/diff/1/appengine/findit/crash/findit.py File appengine/findit/crash/findit.py (right): https://codereview.chromium.org/2673993003/diff/1/appengine/findit/crash/findit.py#newcode45 appengine/findit/crash/findit.py:45: for ``GitilesRepository``). On 2017/02/03 23:58:50, chanli wrote: > nit: ...
3 years, 10 months ago (2017-02-10 23:07:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673993003/60001
3 years, 10 months ago (2017-02-10 23:08:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Infra Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/34431d54f2076d10)
3 years, 10 months ago (2017-02-10 23:14:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673993003/80001
3 years, 10 months ago (2017-02-10 23:49:36 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: Infra Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3443404b386d4910)
3 years, 10 months ago (2017-02-10 23:56:08 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673993003/100001
3 years, 10 months ago (2017-02-11 00:06:53 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 00:16:14 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/infra/infra/+/d4cc688861fbd3e011dcbeb0f71dd...

Powered by Google App Engine
This is Rietveld 408576698