Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: appengine/findit/crash/test/findit_test.py

Issue 2673993003: [Predator] Pass config as argument to findit. (Closed)
Patch Set: Fix pylint. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/findit_test.py
diff --git a/appengine/findit/crash/test/findit_test.py b/appengine/findit/crash/test/findit_test.py
index b55065156494254abb941c9ee3beee9d7a0dacaf..5bdbe9ce07fd0f25f0fe300386d2ee7114e98761 100644
--- a/appengine/findit/crash/test/findit_test.py
+++ b/appengine/findit/crash/test/findit_test.py
@@ -10,9 +10,9 @@ from google.appengine.api import app_identity
from crash.findit import Findit
from crash.type_enums import CrashClient
from crash.test.predator_testcase import PredatorTestCase
+from model.crash.crash_config import CrashConfig
from model.crash.fracas_crash_analysis import FracasCrashAnalysis
-
MOCK_GET_REPOSITORY = lambda _: None # pragma: no cover
@@ -23,22 +23,22 @@ class UnsupportedClient(Findit): # pylint: disable=W0223
return self._client_id
@property
- def config(self): # pragma: no cover
+ def client_config(self): # pragma: no cover
"""Don't return None, so that PlatformRename doesn't crash."""
return {}
- def __init__(self, client_id=None):
- super(UnsupportedClient, self).__init__(MOCK_GET_REPOSITORY)
+ def __init__(self, client_id=None, config=None):
if client_id is None:
client_id = 'unsupported_client'
self._client_id = client_id
+ super(UnsupportedClient, self).__init__(MOCK_GET_REPOSITORY, config)
class MockFindit(Findit): # pylint: disable = W
"""Overwrite abstract method of Findit for testing."""
- def __init__(self):
- super(MockFindit, self).__init__(MOCK_GET_REPOSITORY)
+ def __init__(self, config=None):
+ super(MockFindit, self).__init__(MOCK_GET_REPOSITORY, config)
@classmethod
def _ClientID(cls):
@@ -52,21 +52,23 @@ class FinditTest(PredatorTestCase):
def setUp(self):
super(FinditTest, self).setUp()
- self.findit = MockFindit()
+ self.findit = MockFindit(CrashConfig.Get())
def testPlatformRename(self):
self.assertEqual(
self.findit.RenamePlatform('linux'), 'unix')
def testCheckPolicyUnsupportedClient(self):
- self.assertIsNone(UnsupportedClient().CheckPolicy(self.GetDummyCrashData(
- platform = 'canary',
- signature = 'sig',
- )))
+ self.assertIsNone(UnsupportedClient(config=CrashConfig.Get()).CheckPolicy(
+ self.GetDummyCrashData(
+ platform = 'canary',
+ signature = 'sig',
+ )))
def testCreateAnalysisForUnsupportedClientId(self):
- self.assertIsNone(UnsupportedClient('unsupported_id').CreateAnalysis(
- {'signature': 'sig'}))
+ unsupported_client = UnsupportedClient('unsupported_id',
+ config=CrashConfig.Get())
+ self.assertIsNone(unsupported_client.CreateAnalysis({'signature': 'sig'}))
def testGetAnalysisForUnsuportedClient(self):
crash_identifiers = {'signature': 'sig'}
@@ -76,8 +78,10 @@ class FinditTest(PredatorTestCase):
# base class.
analysis = FracasCrashAnalysis.Create(crash_identifiers)
analysis.put()
+ unsupported_client = UnsupportedClient('Unsupported_client',
+ config=CrashConfig.Get())
self.assertIsNone(
- UnsupportedClient('Unsupported_client').GetAnalysis(crash_identifiers),
+ unsupported_client.GetAnalysis(crash_identifiers),
'Unsupported client unexpectedly got analysis %s via identifiers %s'
% (analysis, crash_identifiers))
« no previous file with comments | « appengine/findit/crash/test/findit_for_chromecrash_test.py ('k') | appengine/findit/handlers/crash/crash_handler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698