[Predator] Pass config as argument to findit.

appengine/findit/crash/findit_for_chromecrash.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.ext import ndb
 
 from common import appengine_util
 from crash import detect_regression_range
 from crash.chromecrash_parser import ChromeCrashParser
-from crash.component import Component
-from crash.component_classifier import ComponentClassifier
 from crash.findit import Findit
 from crash.loglinear.changelist_classifier import LogLinearChangelistClassifier
 from crash.loglinear.changelist_features.touch_crashed_file_meta import (
     TouchCrashedFileMetaFeature)
 from crash.loglinear.feature import WrapperMetaFeature
 from crash.loglinear.weight import MetaWeight
 from crash.loglinear.weight import Weight
 from crash.predator import Predator
-from crash.project import Project
-from crash.project_classifier import ProjectClassifier
 from crash.type_enums import CrashClient
 from model.crash.cracas_crash_analysis import CracasCrashAnalysis
 from model.crash.crash_config import CrashConfig
 from model.crash.fracas_crash_analysis import FracasCrashAnalysis
 
 # TODO(katesonia): Remove the default value after adding validity check to
 # config.
 _FRACAS_FEEDBACK_URL_TEMPLATE = 'https://%s/crash/fracas-result-feedback?key=%s'
 
 # TODO(wrengr): [Note#1] in many places below we have to do some ugly
@@ skipping 13 matching lines @@
   def _ClientID(cls): # pragma: no cover
     if cls is FinditForChromeCrash:
       logging.warning('FinditForChromeCrash is abstract, '
           'but someone constructed an instance and called _ClientID')
     else:
       logging.warning(
           'FinditForChromeCrash subclass %s forgot to implement _ClientID',
           cls.__name__)
     raise NotImplementedError()
 
-  # TODO(http://crbug.com/659354): remove the dependency on CrashConfig
-  # entirely, by passing the relevant data as arguments to this constructor.
-  def __init__(self, get_repository):
-    super(FinditForChromeCrash, self).__init__(get_repository)
+  def __init__(self, get_repository, config):
+    super(FinditForChromeCrash, self).__init__(get_repository, config)
 
     # TODO(http://crbug.com/687670): Move meta weight initial value to config.
     meta_weight = MetaWeight({
         'TouchCrashedFileMeta': MetaWeight({
             'MinDistance': Weight(1.),
             'TopFrameIndex': Weight(1.),
             'TouchCrashedFile': Weight(1.),
         })
     })
     meta_feature = WrapperMetaFeature(
         [TouchCrashedFileMetaFeature(get_repository)])
 
-    project_classifier_config = CrashConfig.Get().project_classifier
-    projects = [Project(name, path_regexs, function_regexs, host_directories)
-                for name, path_regexs, function_regexs, host_directories
-                in project_classifier_config['project_path_function_hosts']]
-    component_classifier_config = CrashConfig.Get().component_classifier
-    components = [Component(component_name, path_regex, function_regex)
-                  for path_regex, function_regex, component_name
-                  in component_classifier_config['path_function_component']]
-
     # The top_n is the number of frames we want to check to get component or
     # project classifications.
     self._predator = Predator(
         cl_classifier = LogLinearChangelistClassifier(get_repository,
                                                       meta_feature,
                                                       meta_weight),
-        component_classifier = ComponentClassifier(
-            components, component_classifier_config['top_n']),
-        project_classifier = ProjectClassifier(
-            projects, project_classifier_config['top_n'],
-            project_classifier_config['non_chromium_project_rank_priority']))
+        project_classifier = self._project_classifier,
+        component_classifier = self._component_classifier)
 
     self._stacktrace_parser = ChromeCrashParser()
 
   def _InitializeAnalysis(self, model, crash_data):
     super(FinditForChromeCrash, self)._InitializeAnalysis(model, crash_data)
     # TODO(wrengr): see Note#1
     customized_data = crash_data.get('customized_data', {})
     model.channel = customized_data.get('channel', None)
     model.historical_metadata = customized_data.get('historical_metadata', [])
 
@@ skipping 22 matching lines @@
     model.put()
     return True
 
   def CheckPolicy(self, crash_data):
     crash_identifiers = crash_data['crash_identifiers']
     platform = crash_data['platform']
     # TODO(wrengr): see Note#1
     channel = crash_data.get('customized_data', {}).get('channel', None)
     # TODO(katesonia): Remove the default value after adding validity check to
     # config.
-    if platform not in self.config.get(
+    if platform not in self.client_config.get(
         'supported_platform_list_by_channel', {}).get(channel, []):
       # Bail out if either the channel or platform is not supported yet.
       logging.info('Analysis of channel %s, platform %s is not supported. '
                    'No analysis is scheduled for %s',
                    channel, platform, repr(crash_identifiers))
       return None
 
     signature = crash_data['signature']
     # TODO(wrengr): can this blacklist stuff be lifted to the base class?
     # TODO(katesonia): Remove the default value after adding validity check to
     # config.
-    for blacklist_marker in self.config.get('signature_blacklist_markers', []):
+    for blacklist_marker in self.client_config.get(
+        'signature_blacklist_markers', []):
       if blacklist_marker in signature:
         logging.info('%s signature is not supported. '
                      'No analysis is scheduled for %s', blacklist_marker,
                      repr(crash_identifiers))
         return None
 
     # TODO(wrengr): should we clone ``crash_data`` rather than mutating it?
     crash_data['platform'] = self.RenamePlatform(platform)
     return crash_data
 
@@ skipping 36 matching lines @@
 
   def GetAnalysis(self, crash_identifiers):
     # TODO: inline FracasCrashAnalysis.Get stuff here.
     return FracasCrashAnalysis.Get(crash_identifiers)
 
   def ProcessResultForPublishing(self, result, key):
     """Fracas specific processing of result data for publishing."""
     result['feedback_url'] = _FRACAS_FEEDBACK_URL_TEMPLATE % (
         appengine_util.GetDefaultVersionHostname(), key)
     return result