Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 2673963003: Prepare to turn on AreCrossProcessFramesPossible by default. (Closed)

Created:
3 years, 10 months ago by alexmos
Modified:
3 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare to turn on AreCrossProcessFramesPossible by default. This fixes some incorrect expectations in PlzNavigate unittests, which were using the wrong policy function to detect --site-per-process behavior. It also adds a TODO around another problematic use of AreCrossProcessFramesPossible. Split off from creis's http://crrev.com/2668013005. BUG=545200 TEST=No visible behavior change. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2673963003 Cr-Commit-Position: refs/heads/master@{#448380} Committed: https://chromium.googlesource.com/chromium/src/+/ffc4514bb0a9ed6dd10f3745b02e3f58a55fe867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M content/browser/frame_host/navigator_impl_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
alexmos
Nasko, can you please take a look? See the discussion on Charlie's https://codereview.chromium.org/2668013005/; this is ...
3 years, 10 months ago (2017-02-04 02:06:49 UTC) #4
nasko
LGTM
3 years, 10 months ago (2017-02-06 19:17:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673963003/1
3 years, 10 months ago (2017-02-06 19:18:07 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 20:41:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ffc4514bb0a9ed6dd10f3745b02e...

Powered by Google App Engine
This is Rietveld 408576698