Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2676823003: Turn on AreCrossProcessFramesPossible by default. (Closed)

Created:
3 years, 10 months ago by alexmos
Modified:
3 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on AreCrossProcessFramesPossible by default. This turns on all of the plumbing required to create out-of-process iframes, without enabling any policies that create them in practice. This minimizes the difference between OOPIF and non-OOPIF modes. Behavior changes include: - Creating proxies for child frames and replicating state to them - Enabling cross-process policy checks for child frame navigations - More complex fullscreen toggling logic - Slightly different event routing and focus logic Split off from creis's http://crrev.com/2668013005. BUG=545200 TEST=No visible behavior change. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2676823003 Cr-Commit-Position: refs/heads/master@{#448761} Committed: https://chromium.googlesource.com/chromium/src/+/443064bb9932a98ad47c1cbbf8bba2493a31f888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M content/common/site_isolation_policy.cc View 1 chunk +1 line, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
alexmos
Nasko, can you please take a look at this after https://codereview.chromium.org/2673963003/?
3 years, 10 months ago (2017-02-04 02:07:59 UTC) #4
nasko
LGTM
3 years, 10 months ago (2017-02-06 19:19:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676823003/1
3 years, 10 months ago (2017-02-07 20:51:52 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 22:53:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/443064bb9932a98ad47c1cbbf8bb...

Powered by Google App Engine
This is Rietveld 408576698