Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 2673963003: Prepare to turn on AreCrossProcessFramesPossible by default. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index ebba6861f7850377f4ddefd0b5755bc37631382e..6de0f24d8ae81b9428617f5287e1fd7fc76a9562 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -1098,6 +1098,9 @@ bool RenderFrameHostManager::ShouldTransitionCrossSite() {
// TODO(nick): Move all handling of kSingleProcess/kProcessPerTab into
// SiteIsolationPolicy so we have a consistent behavior around the interaction
// of the process model flags.
+ //
+ // TODO(creis, alexmos): This looks like it will break single-process and
+ // process-per-tab. See https://crbug.com/688617.
if (SiteIsolationPolicy::AreCrossProcessFramesPossible())
return true;
« no previous file with comments | « content/browser/frame_host/navigator_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698