Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2673783002: MD Settings: Add Protected Content toggle to Site Settings (Closed)

Created:
3 years, 10 months ago by tommycli
Modified:
3 years, 10 months ago
Reviewers:
dschuyler, stevenjb, dpapad
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add Protected Content toggle to Site Settings Adds the toggle with the same text as the Old Options. The site exceptions portion is not included in this CL. BUG=687783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2673783002 Cr-Commit-Position: refs/heads/master@{#448133} Committed: https://chromium.googlesource.com/chromium/src/+/2e34f7eb3596b5ff981a4d1554bec36765e23f5d

Patch Set 1 #

Patch Set 2 : new and alan approved #

Total comments: 2

Patch Set 3 : add no-search #

Total comments: 7

Patch Set 4 : address comments #

Messages

Total messages: 36 (20 generated)
tommycli
dschuyler: PTAL, thanks!
3 years, 10 months ago (2017-02-02 23:25:14 UTC) #5
tommycli
On 2017/02/02 23:25:14, tommycli wrote: > dschuyler: PTAL, thanks! Screenshots in c#4 of bug.
3 years, 10 months ago (2017-02-02 23:48:54 UTC) #7
tommycli
dpapad ptal, thanks!
3 years, 10 months ago (2017-02-03 20:18:52 UTC) #12
dpapad
https://codereview.chromium.org/2673783002/diff/20001/chrome/browser/resources/settings/privacy_page/privacy_page.html File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2673783002/diff/20001/chrome/browser/resources/settings/privacy_page/privacy_page.html#newcode442 chrome/browser/resources/settings/privacy_page/privacy_page.html:442: <settings-subpage page-title="$i18n{siteSettingsProtectedContent}"> I think this blows up searching. Every ...
3 years, 10 months ago (2017-02-03 22:03:14 UTC) #13
dpapad
On 2017/02/03 at 22:03:14, dpapad wrote: > https://codereview.chromium.org/2673783002/diff/20001/chrome/browser/resources/settings/privacy_page/privacy_page.html > File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): > > https://codereview.chromium.org/2673783002/diff/20001/chrome/browser/resources/settings/privacy_page/privacy_page.html#newcode442 ...
3 years, 10 months ago (2017-02-03 22:04:26 UTC) #14
tommycli
thanks! https://codereview.chromium.org/2673783002/diff/20001/chrome/browser/resources/settings/privacy_page/privacy_page.html File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2673783002/diff/20001/chrome/browser/resources/settings/privacy_page/privacy_page.html#newcode442 chrome/browser/resources/settings/privacy_page/privacy_page.html:442: <settings-subpage page-title="$i18n{siteSettingsProtectedContent}"> On 2017/02/03 22:03:14, dpapad wrote: > ...
3 years, 10 months ago (2017-02-03 22:09:15 UTC) #16
dpapad
https://codereview.chromium.org/2673783002/diff/40001/chrome/browser/resources/settings/privacy_page/privacy_page.html File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2673783002/diff/40001/chrome/browser/resources/settings/privacy_page/privacy_page.html#newcode441 chrome/browser/resources/settings/privacy_page/privacy_page.html:441: <template is="dom-if" route-path="/content/protectedContent"> Is this worth a test? There ...
3 years, 10 months ago (2017-02-03 22:20:14 UTC) #18
tommycli
thanks! https://codereview.chromium.org/2673783002/diff/40001/chrome/browser/resources/settings/privacy_page/privacy_page.html File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2673783002/diff/40001/chrome/browser/resources/settings/privacy_page/privacy_page.html#newcode441 chrome/browser/resources/settings/privacy_page/privacy_page.html:441: <template is="dom-if" route-path="/content/protectedContent"> On 2017/02/03 22:20:14, dpapad wrote: ...
3 years, 10 months ago (2017-02-03 22:50:51 UTC) #19
dpapad
LGTM https://codereview.chromium.org/2673783002/diff/40001/chrome/browser/resources/settings/privacy_page/privacy_page.html File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): https://codereview.chromium.org/2673783002/diff/40001/chrome/browser/resources/settings/privacy_page/privacy_page.html#newcode441 chrome/browser/resources/settings/privacy_page/privacy_page.html:441: <template is="dom-if" route-path="/content/protectedContent"> On 2017/02/03 at 22:50:51, tommycli ...
3 years, 10 months ago (2017-02-03 23:06:20 UTC) #22
tommycli
On 2017/02/03 23:06:20, dpapad wrote: > LGTM > > https://codereview.chromium.org/2673783002/diff/40001/chrome/browser/resources/settings/privacy_page/privacy_page.html > File chrome/browser/resources/settings/privacy_page/privacy_page.html (right): > ...
3 years, 10 months ago (2017-02-03 23:09:52 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673783002/60001
3 years, 10 months ago (2017-02-03 23:10:39 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/356700)
3 years, 10 months ago (2017-02-03 23:18:39 UTC) #28
tommycli
stevenjb: PTAL prefs_util.cc thanks!
3 years, 10 months ago (2017-02-03 23:23:17 UTC) #30
stevenjb
lgtm
3 years, 10 months ago (2017-02-03 23:29:14 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673783002/60001
3 years, 10 months ago (2017-02-03 23:37:15 UTC) #33
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 00:56:07 UTC) #36
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2e34f7eb3596b5ff981a4d1554be...

Powered by Google App Engine
This is Rietveld 408576698