MD Settings: Add Protected Content Content Settings exceptions

MD Settings: Add Protected Content Content Settings exceptions

BUG=687783
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2673633003
Cr-Commit-Position: refs/heads/master@{#448493}
Committed: https://chromium.googlesource.com/chromium/src/+/0c3ce60724a6c3ac94ecd335effc7608cb045625

[tommycli, 2017-02-02 23:58:42]

Description was changed from

==========
MD Settings: Add Protected Content Content Settings exceptions

BUG=687783
==========

to

==========
MD Settings: Add Protected Content Content Settings exceptions

BUG=687783
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-02-02 23:59:45]

tommycli@chromium.org changed reviewers:
+ dschuyler@chromium.org

[tommycli, 2017-02-02 23:59:45]

dschuyler: PTAL followup to prev. CL.

Screenshot here: https://bugs.chromium.org/p/chromium/issues/detail?id=687783#c6

[tommycli, 2017-02-03 20:19:05]

tommycli@chromium.org changed reviewers:
+ dpapad@chromium.org

[tommycli, 2017-02-03 20:19:05]

dpapad: PTAL followup cl thanks!

[dpapad, 2017-02-03 22:54:11]

https://codereview.chromium.org/2673633003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2673633003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:449: <if
expr="chromeos">
The "Protected Content" section is present on both Win and ChromeOS. Are the
exceptions ChromeOS only on purpose?

[tommycli, 2017-02-03 22:58:47]

https://codereview.chromium.org/2673633003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2673633003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:449: <if
expr="chromeos">
On 2017/02/03 22:54:11, dpapad wrote:
> The "Protected Content" section is present on both Win and ChromeOS. Are the
> exceptions ChromeOS only on purpose?

Yessir see here for the Options equivalent code:
https://cs.chromium.org/chromium/src/chrome/browser/resources/options/content...

[dpapad, 2017-02-03 23:09:22]

LGTM

https://codereview.chromium.org/2673633003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/2673633003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:449: <if
expr="chromeos">
On 2017/02/03 at 22:58:47, tommycli wrote:
> On 2017/02/03 22:54:11, dpapad wrote:
> > The "Protected Content" section is present on both Win and ChromeOS. Are the
> > exceptions ChromeOS only on purpose?
> 
> Yessir see here for the Options equivalent code:
https://cs.chromium.org/chromium/src/chrome/browser/resources/options/content...

Thanks for the link.

[tommycli, 2017-02-06 16:48:46]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:49:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 17:47:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 17:47:35]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tommycli, 2017-02-06 18:39:57]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 18:40:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 18:42:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 18:42:46]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tommycli, 2017-02-06 18:53:06]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 18:53:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-02-06 19:44:21]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-02-06 19:44:21]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-02-06 19:44:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2673633003/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2017-02-06 19:45:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 21:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 21:14:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2017-02-06 23:11:50]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 23:12:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-02-07 00:33:46]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-02-07 00:33:47]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-02-07 00:33:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2673633003/#ps60001
(title: "update tests")

[commit-bot: I haz the power, 2017-02-07 00:34:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 01:24:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486427627234320,
"parent_rev": "441f2c5583174d5411ced1d308007b34a055a4fb", "commit_rev":
"0c3ce60724a6c3ac94ecd335effc7608cb045625"}

[commit-bot: I haz the power, 2017-02-07 01:24:59]

Description was changed from

==========
MD Settings: Add Protected Content Content Settings exceptions

BUG=687783
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add Protected Content Content Settings exceptions

BUG=687783
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2673633003
Cr-Commit-Position: refs/heads/master@{#448493}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c3ce60724a6c3ac94ecd335effc...
==========

[commit-bot: I haz the power, 2017-02-07 01:25:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0c3ce60724a6c3ac94ecd335effc...