Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2677193004: MD Settings: Add description for Protected Content (Closed)

Created:
3 years, 10 months ago by tommycli
Modified:
3 years, 10 months ago
Reviewers:
srahim, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add description for Protected Content Adds the explanation for Protected Content toggle. BUG=687783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2677193004 Cr-Commit-Position: refs/heads/master@{#448497} Committed: https://chromium.googlesource.com/chromium/src/+/ad7fe40bd171138a8c8b31c7f68b5e05d6761ea6

Patch Set 1 #

Patch Set 2 : add two-line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
tommycli
srahim, dpapad: PTAL Screenshot: http://imgur.com/a/em3oT
3 years, 10 months ago (2017-02-06 23:48:40 UTC) #3
dpapad
lgtm
3 years, 10 months ago (2017-02-07 00:06:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677193004/20001
3 years, 10 months ago (2017-02-07 00:17:31 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 01:30:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ad7fe40bd171138a8c8b31c7f68b...

Powered by Google App Engine
This is Rietveld 408576698