[Predator] Add CrashData class to process raw json crash data.

[Predator] Add CrashData class to process raw json crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies`` and ``dependency_rolls`` should be analyzed in ``CrashData``, and those information will finally convert to ``CrashReport`` to be passed to Predator library.

This cl (https://codereview.chromium.org/2663063007/) switches from the anonymous dict to ``CrashData``.  

The motivation is that ``crash_data`` sent by different clients are very different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=688578
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2673733002
Committed: https://chromium.googlesource.com/infra/infra/+/0bc6605f33f8f2e26fab0058610a5874c858c1ef

[Sharu Jiang, 2017-02-02 22:33:00]

Patchset #1 (id:1) has been deleted

[Sharu Jiang, 2017-02-02 22:39:45]

Patchset #1 (id:20001) has been deleted

[Sharu Jiang, 2017-02-02 22:44:16]

Description was changed from

==========
[Predator] Add CrashBuffer to process crash data.

BUG=
==========

to

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

BUG=
==========

[Sharu Jiang, 2017-02-02 22:44:16]

katesonia@chromium.org changed reviewers:
+ mbarbella@chromium.org, wrengr@chromium.org

[Sharu Jiang, 2017-02-02 23:32:42]

Description was changed from

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

BUG=
==========

to

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

BUG=
==========

[Sharu Jiang, 2017-02-02 23:33:37]

PTAL.

[Sharu Jiang, 2017-02-03 01:01:21]

Patchset #1 (id:40001) has been deleted

[Sharu Jiang, 2017-02-03 06:58:06]

Patchset #1 (id:60001) has been deleted

[Sharu Jiang, 2017-02-03 06:58:14]

Patchset #1 (id:80001) has been deleted

[wrengr, 2017-02-03 18:40:50]

Could you explain a bit what the motivation is for this? What does it clean up
or make easier to follow?

In other cases when we have a buffer object it's because we need to build
something up by pieces before we can make it immutable; but that's not what the
old code was doing. The old code did the analysis all in one go, so I'm not sure
what needs to be buffered...

[Sharu Jiang, 2017-02-03 21:39:20]

On 2017/02/03 18:40:50, wrengr wrote:
> Could you explain a bit what the motivation is for this? What does it clean up
> or make easier to follow?

The motivation is crash_data sent by different clients are very different, we'd
better proeccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize them).

> 
> In other cases when we have a buffer object it's because we need to build
> something up by pieces before we can make it immutable; but that's not what
the
> old code was doing. The old code did the analysis all in one go, so I'm not
sure
> what needs to be buffered...

CrashBuffer may not be the best name, but as one of your note, we need a proper
class for crash_data, this is a class of parsed crash_data.

[Sharu Jiang, 2017-02-03 21:39:40]

Description was changed from

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

BUG=
==========

to

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

The motivation is crash_data sent by different clients are very different, we'd
better proeccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize them).

BUG=
==========

[Sharu Jiang, 2017-02-03 21:40:04]

Description was changed from

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

The motivation is crash_data sent by different clients are very different, we'd
better proeccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize them).

BUG=
==========

to

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize them).

BUG=
==========

[Sharu Jiang, 2017-02-03 21:40:25]

Description was changed from

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize them).

BUG=
==========

to

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=
==========

[Sharu Jiang, 2017-02-03 21:42:34]

On 2017/02/03 21:39:20, Sharu Jiang wrote:
> On 2017/02/03 18:40:50, wrengr wrote:
> > Could you explain a bit what the motivation is for this? What does it clean
up
> > or make easier to follow?
> 
> The motivation is crash_data sent by different clients are very different,
we'd
> better proeccess the raw crash_data dict before we actually analyze them
((like
> ``CheckPolicy``, ``NeedsNewAnalysis`` or initialize them).
> 
> > 
> > In other cases when we have a buffer object it's because we need to build
> > something up by pieces before we can make it immutable; but that's not what
> the
> > old code was doing. The old code did the analysis all in one go, so I'm not
> sure
> > what needs to be buffered...
> 
> CrashBuffer may not be the best name, but as one of your note, we need a
proper
> class for crash_data, this is a class of parsed crash_data.

How about just name it ``CrashData``?

[Sharu Jiang, 2017-02-03 23:20:10]

Description was changed from

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=
==========

to

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=688578
==========

[Sharu Jiang, 2017-02-06 20:36:22]

Patchset #2 (id:120001) has been deleted

[Sharu Jiang, 2017-02-06 20:37:02]

Ping :)

[Sharu Jiang, 2017-02-06 20:38:27]

Description was changed from

==========
[Predator] Add CrashBuffer to process crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashBuffer``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashBuffer``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=688578
==========

to

==========
[Predator] Add CrashData class to process raw json crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashData``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashData``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=688578
==========

[Martin Barbella, 2017-02-06 21:16:12]

lgtm

https://codereview.chromium.org/2673733002/diff/140001/appengine/findit/crash...
File appengine/findit/crash/changelist_classifier.py (right):

https://codereview.chromium.org/2673733002/diff/140001/appengine/findit/crash...
appengine/findit/crash/changelist_classifier.py:202: for dep in stack_deps or
[]:
At a glance it seems like it'd be cleaner to ensure that stack_deps is iterable
wherever we create it. In the event that we start using it in other places
later, we'd have to add these same kinds of checks.

https://codereview.chromium.org/2673733002/diff/140001/appengine/findit/crash...
File appengine/findit/crash/chrome_crash_data.py (right):

https://codereview.chromium.org/2673733002/diff/140001/appengine/findit/crash...
appengine/findit/crash/chrome_crash_data.py:203: return has_both_revisions
Blank line after this for readability.

[Sharu Jiang, 2017-02-10 22:07:11]

Patchset #4 (id:180001) has been deleted

[Sharu Jiang, 2017-02-10 22:07:20]

https://codereview.chromium.org/2673733002/diff/140001/appengine/findit/crash...
File appengine/findit/crash/changelist_classifier.py (right):

https://codereview.chromium.org/2673733002/diff/140001/appengine/findit/crash...
appengine/findit/crash/changelist_classifier.py:202: for dep in stack_deps or
[]:
On 2017/02/06 21:16:12, Martin Barbella wrote:
> At a glance it seems like it'd be cleaner to ensure that stack_deps is
iterable
> wherever we create it. In the event that we start using it in other places
> later, we'd have to add these same kinds of checks.

Done.

https://codereview.chromium.org/2673733002/diff/140001/appengine/findit/crash...
File appengine/findit/crash/chrome_crash_data.py (right):

https://codereview.chromium.org/2673733002/diff/140001/appengine/findit/crash...
appengine/findit/crash/chrome_crash_data.py:203: return has_both_revisions
On 2017/02/06 21:16:12, Martin Barbella wrote:
> Blank line after this for readability.

Done.

[Sharu Jiang, 2017-02-10 22:18:46]

The CQ bit was checked by katesonia@chromium.org

[Sharu Jiang, 2017-02-10 22:18:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
mbarbella@chromium.org
Link to the patchset: https://codereview.chromium.org/2673733002/#ps200001
(title: "Rebase and fix nits.")

[commit-bot: I haz the power, 2017-02-10 22:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 22:18:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:18:56]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[Sharu Jiang, 2017-02-10 22:20:11]

Description was changed from

==========
[Predator] Add CrashData class to process raw json crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashData``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashData``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=688578
==========

to

==========
[Predator] Add CrashData class to process raw json crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashData``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashData``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=688578
TBR=stgao@chromium.org
==========

[Sharu Jiang, 2017-02-10 22:21:26]

The CQ bit was checked by katesonia@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:21:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 22:29:52]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1486765286643280,
"parent_rev": "c3d8f204b7ca10c0cd8489fe119288c20b8ccf6f", "commit_rev":
"0bc6605f33f8f2e26fab0058610a5874c858c1ef"}

[commit-bot: I haz the power, 2017-02-10 22:29:55]

Description was changed from

==========
[Predator] Add CrashData class to process raw json crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashData``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashData``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=688578
TBR=stgao@chromium.org
==========

to

==========
[Predator] Add CrashData class to process raw json crash data.

All the information like ``regression_range``, ``stacktrace``, ``dependencies``
and ``dependency_rolls`` should be analyzed in ``CrashData``, and those
information will finally convert to ``CrashReport`` to be passed to Predator
library.

This cl (https://codereview.chromium.org/2663063007/) switches from the
anonymous dict to ``CrashData``.  

The motivation is that ``crash_data`` sent by different clients are very
different, we'd
better proccess the raw crash_data dict before we actually analyze them ((like
``CheckPolicy``, ``NeedsNewAnalysis`` or initialize model using crash data).

BUG=688578
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2673733002
Committed:
https://chromium.googlesource.com/infra/infra/+/0bc6605f33f8f2e26fab0058610a5...
==========

[commit-bot: I haz the power, 2017-02-10 22:29:56]

Committed patchset #4 (id:200001) as
https://chromium.googlesource.com/infra/infra/+/0bc6605f33f8f2e26fab0058610a5...