Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: appengine/findit/crash/test/crash_pipeline_test.py

Issue 2673733002: [Predator] Add CrashData class to process raw json crash data. (Closed)
Patch Set: Rebase and fix nits. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/crash_pipeline_test.py
diff --git a/appengine/findit/crash/test/crash_pipeline_test.py b/appengine/findit/crash/test/crash_pipeline_test.py
index c11c412de376e87da271d9417739c0bf7cbaf270..d03973f98917aeb14be1d7cea769049303878642 100644
--- a/appengine/findit/crash/test/crash_pipeline_test.py
+++ b/appengine/findit/crash/test/crash_pipeline_test.py
@@ -15,48 +15,11 @@ from model import analysis_status
from model.crash.fracas_crash_analysis import FracasCrashAnalysis
-def DummyCrashData(
- client_id=None,
- version='1',
- signature='signature',
- platform='win',
- stack_trace=None,
- regression_range=None,
- channel='canary',
- historical_metadata=None,
- crash_identifiers=True,
- process_type='browser'):
- if crash_identifiers is True: # pragma: no cover
- crash_identifiers = {
- 'chrome_version': version,
- 'signature': signature,
- 'channel': channel,
- 'platform': platform,
- 'process_type': process_type,
- }
- crash_data = {
- 'crashed_version': version,
- 'signature': signature,
- 'platform': platform,
- 'stack_trace': stack_trace,
- 'regression_range': regression_range,
- 'crash_identifiers': crash_identifiers,
- 'customized_data': {
- 'historical_metadata': historical_metadata,
- 'channel': channel,
- },
- }
- # This insertion of client_id is used for debugging ScheduleNewAnalysis.
- if client_id is not None: # pragma: no cover
- crash_data['client_id'] = client_id
- return crash_data
-
-
class CrashPipelineTest(PredatorTestCase):
app_module = pipeline_handlers._APP
def testAnalysisAborted(self):
- crash_identifiers = DummyCrashData()['crash_identifiers']
+ crash_identifiers = self.GetDummyCrashData()['crash_identifiers']
analysis = FracasCrashAnalysis.Create(crash_identifiers)
analysis.status = analysis_status.RUNNING
analysis.put()
@@ -69,7 +32,7 @@ class CrashPipelineTest(PredatorTestCase):
self.assertEqual(analysis_status.ERROR, analysis.status)
def testFindCulpritFails(self):
- crash_identifiers = DummyCrashData()['crash_identifiers']
+ crash_identifiers = self.GetDummyCrashData()['crash_identifiers']
analysis = FracasCrashAnalysis.Create(crash_identifiers)
analysis.status = analysis_status.RUNNING
analysis.put()
@@ -88,7 +51,7 @@ class CrashPipelineTest(PredatorTestCase):
self.assertFalse(analysis.found_components)
def testFindCulpritSucceeds(self):
- crash_identifiers = DummyCrashData()['crash_identifiers']
+ crash_identifiers = self.GetDummyCrashData()['crash_identifiers']
analysis = FracasCrashAnalysis.Create(crash_identifiers)
analysis.status = analysis_status.RUNNING
analysis.put()
« no previous file with comments | « appengine/findit/crash/test/crash_data_test.py ('k') | appengine/findit/crash/test/findit_for_chromecrash_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698