Rename SwapBuffersWithDamage to SwapBuffersWithBounds

Rename SwapBuffersWithDamage to SwapBuffersWithBounds

SwapBuffersWithDamage was added for power savings on Chromecast
(see bug), but there is a semantic mismatch: we actually want to
pass non-overlay content bounds through to graphics driver, not
damage rect.

This renames the API to SwapBuffersWithBounds and hides the misuse
of 'swap with damage' API inside GLSurfaceCast.  Will fix that
separately when we have a different EGL extension name for the API.

BUG=687690
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2673473002
Cr-Commit-Position: refs/heads/master@{#448269}
Committed: https://chromium.googlesource.com/chromium/src/+/53242f17bf9b441c048511dfd2352e38326ef193

[halliwell, 2017-02-01 20:32:06]

Description was changed from

==========
Rename SwapBuffersWithDamage to SwapBuffersWithBounds

SwapBuffersWithDamage was added for power savings on Chromecast
(see bug), but there is a semantic mismatch: we actually want to
pass non-overlay content bounds through to graphics driver, not
damage rect.

This renames the API to SwapBuffersWithBounds and hides the misuse
of 'swap with damage' API inside GLSurfaceCast.  Will fix that
separately when we have a different EGL extension name for the API.

BUG=687690
==========

to

==========
Rename SwapBuffersWithDamage to SwapBuffersWithBounds

SwapBuffersWithDamage was added for power savings on Chromecast
(see bug), but there is a semantic mismatch: we actually want to
pass non-overlay content bounds through to graphics driver, not
damage rect.

This renames the API to SwapBuffersWithBounds and hides the misuse
of 'swap with damage' API inside GLSurfaceCast.  Will fix that
separately when we have a different EGL extension name for the API.

BUG=687690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[halliwell, 2017-02-01 20:32:07]

Description was changed from

==========
Rename SwapBuffersWithDamage to SwapBuffersWithBounds

SwapBuffersWithDamage was added for power savings on Chromecast
(see bug), but there is a semantic mismatch: we actually want to
pass non-overlay content bounds through to graphics driver, not
damage rect.

This renames the API to SwapBuffersWithBounds and hides the misuse
of 'swap with damage' API inside GLSurfaceCast.  Will fix that
separately when we have a different EGL extension name for the API.

BUG=687690
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Rename SwapBuffersWithDamage to SwapBuffersWithBounds

SwapBuffersWithDamage was added for power savings on Chromecast
(see bug), but there is a semantic mismatch: we actually want to
pass non-overlay content bounds through to graphics driver, not
damage rect.

This renames the API to SwapBuffersWithBounds and hides the misuse
of 'swap with damage' API inside GLSurfaceCast.  Will fix that
separately when we have a different EGL extension name for the API.

BUG=687690
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[halliwell, 2017-02-01 20:33:03]

Description was changed from

==========
Rename SwapBuffersWithDamage to SwapBuffersWithBounds

SwapBuffersWithDamage was added for power savings on Chromecast
(see bug), but there is a semantic mismatch: we actually want to
pass non-overlay content bounds through to graphics driver, not
damage rect.

This renames the API to SwapBuffersWithBounds and hides the misuse
of 'swap with damage' API inside GLSurfaceCast.  Will fix that
separately when we have a different EGL extension name for the API.

BUG=687690
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename SwapBuffersWithDamage to SwapBuffersWithBounds

SwapBuffersWithDamage was added for power savings on Chromecast
(see bug), but there is a semantic mismatch: we actually want to
pass non-overlay content bounds through to graphics driver, not
damage rect.

This renames the API to SwapBuffersWithBounds and hides the misuse
of 'swap with damage' API inside GLSurfaceCast.  Will fix that
separately when we have a different EGL extension name for the API.

BUG=687690
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[halliwell, 2017-02-01 20:33:03]

halliwell@chromium.org changed reviewers:
+ jbauman@chromium.org

[jbauman, 2017-02-01 22:15:04]

lgtm

[halliwell, 2017-02-01 23:54:08]

halliwell@chromium.org changed reviewers:
+ danakj@chromium.org, meacer@chromium.org

[halliwell, 2017-02-01 23:55:00]

+ danakj for cc/test
+ meacer for gpu/ipc

[halliwell, 2017-02-01 23:55:12]

The CQ bit was checked by halliwell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 23:55:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 00:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 00:16:29]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[danakj, 2017-02-02 16:23:39]

cc/test/ LGTM

[meacer, 2017-02-02 21:42:33]

gpu/ipc lgtm

https://codereview.chromium.org/2673473002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2673473002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:916: // Wrapper for
SwapBuffersWithBoundsCHROMIUM
nit: missing period at the end.

https://codereview.chromium.org/2673473002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc (right):

https://codereview.chromium.org/2673473002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc:2674: for
(GLsizei i = 0; i != count; ++i) {
Why not i < count?

https://codereview.chromium.org/2673473002/diff/20001/ui/ozone/platform/cast/...
File ui/ozone/platform/cast/gl_surface_cast.cc (right):

https://codereview.chromium.org/2673473002/diff/20001/ui/ozone/platform/cast/...
ui/ozone/platform/cast/gl_surface_cast.cc:39: // TODO(halliwell): request new
EGL extension so we're not abusing
nit: request -> Request

[halliwell, 2017-02-03 20:17:01]

https://codereview.chromium.org/2673473002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2673473002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:916: // Wrapper for
SwapBuffersWithBoundsCHROMIUM
On 2017/02/02 21:42:33, Mustafa Emre Acer wrote:
> nit: missing period at the end.

Done.

https://codereview.chromium.org/2673473002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc (right):

https://codereview.chromium.org/2673473002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc:2674: for
(GLsizei i = 0; i != count; ++i) {
On 2017/02/02 21:42:33, Mustafa Emre Acer wrote:
> Why not i < count?

Old habit :)  Updated to <

https://codereview.chromium.org/2673473002/diff/20001/ui/ozone/platform/cast/...
File ui/ozone/platform/cast/gl_surface_cast.cc (right):

https://codereview.chromium.org/2673473002/diff/20001/ui/ozone/platform/cast/...
ui/ozone/platform/cast/gl_surface_cast.cc:39: // TODO(halliwell): request new
EGL extension so we're not abusing
On 2017/02/02 21:42:33, Mustafa Emre Acer wrote:
> nit: request -> Request

Done.

[halliwell, 2017-02-03 20:18:40]

The CQ bit was checked by halliwell@chromium.org

[halliwell, 2017-02-03 20:18:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbauman@chromium.org, danakj@chromium.org, meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2673473002/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2017-02-03 20:19:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 20:59:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 21:00:00]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[halliwell, 2017-02-06 15:28:57]

The CQ bit was checked by halliwell@chromium.org

[halliwell, 2017-02-06 15:28:58]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
jbauman@chromium.org, meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2673473002/#ps60001
(title: "fix windows compile warning")

[commit-bot: I haz the power, 2017-02-06 15:29:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 16:27:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486394937911040,
"parent_rev": "0a80c26dfe96dc2ac2233c0840fe10bbb3c67dad", "commit_rev":
"53242f17bf9b441c048511dfd2352e38326ef193"}

[commit-bot: I haz the power, 2017-02-06 16:27:37]

Description was changed from

==========
Rename SwapBuffersWithDamage to SwapBuffersWithBounds

SwapBuffersWithDamage was added for power savings on Chromecast
(see bug), but there is a semantic mismatch: we actually want to
pass non-overlay content bounds through to graphics driver, not
damage rect.

This renames the API to SwapBuffersWithBounds and hides the misuse
of 'swap with damage' API inside GLSurfaceCast.  Will fix that
separately when we have a different EGL extension name for the API.

BUG=687690
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename SwapBuffersWithDamage to SwapBuffersWithBounds

SwapBuffersWithDamage was added for power savings on Chromecast
(see bug), but there is a semantic mismatch: we actually want to
pass non-overlay content bounds through to graphics driver, not
damage rect.

This renames the API to SwapBuffersWithBounds and hides the misuse
of 'swap with damage' API inside GLSurfaceCast.  Will fix that
separately when we have a different EGL extension name for the API.

BUG=687690
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2673473002
Cr-Commit-Position: refs/heads/master@{#448269}
Committed:
https://chromium.googlesource.com/chromium/src/+/53242f17bf9b441c048511dfd235...
==========

[commit-bot: I haz the power, 2017-02-06 16:27:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/53242f17bf9b441c048511dfd235...