Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 2673473002: Rename SwapBuffersWithDamage to SwapBuffersWithBounds (Closed)
Patch Set: fix windows compile warning Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/GLES2/gl2chromium_autogen.h ('k') | gpu/command_buffer/client/context_support.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
diff --git a/gpu/command_buffer/build_gles2_cmd_buffer.py b/gpu/command_buffer/build_gles2_cmd_buffer.py
index f6454ca8f17c3d0d2919fd94c46912d5850a3623..bbb60373867a80f824548be19ebf11b6b58dec11 100755
--- a/gpu/command_buffer/build_gles2_cmd_buffer.py
+++ b/gpu/command_buffer/build_gles2_cmd_buffer.py
@@ -3373,7 +3373,6 @@ _FUNCTION_INFO = {
'type': 'PUTn',
'count': 1,
'decoder_func': 'DoInvalidateFramebuffer',
- 'client_test': False,
'unit_test': False,
'es3': True,
},
@@ -3381,7 +3380,6 @@ _FUNCTION_INFO = {
'type': 'PUTn',
'count': 1,
'decoder_func': 'DoInvalidateSubFramebuffer',
- 'client_test': False,
'unit_test': False,
'es3': True,
},
@@ -3654,8 +3652,10 @@ _FUNCTION_INFO = {
'extension': True,
'trace_level': 1,
},
- 'SwapBuffersWithDamageCHROMIUM': {
- 'type': 'Custom',
+ 'SwapBuffersWithBoundsCHROMIUM': {
+ 'type': 'PUTn',
+ 'count': 4,
+ 'decoder_func': 'DoSwapBuffersWithBoundsCHROMIUM',
'impl_func': False,
'client_test': False,
'extension': True,
@@ -4081,7 +4081,6 @@ _FUNCTION_INFO = {
'type': 'PUTn',
'decoder_func': 'DoDrawBuffersEXT',
'count': 1,
- 'client_test': False,
'unit_test': False,
# could use 'extension_flag': 'ext_draw_buffers' but currently expected to
# work without.
@@ -4328,7 +4327,6 @@ _FUNCTION_INFO = {
'count': 1,
'decoder_func': 'DoDiscardFramebufferEXT',
'unit_test': False,
- 'client_test': False,
'extension': 'EXT_discard_framebuffer',
'extension_flag': 'ext_discard_framebuffer',
'trace_level': 2,
@@ -7335,6 +7333,9 @@ TEST_P(%(test_name)s, %(name)sInvalidArgs%(arg_index)d_%(value_index)d) {
def WriteGLES2Implementation(self, func, f):
"""Overrriden from TypeHandler."""
+ impl_func = func.GetInfo('impl_func')
+ if (impl_func != None and impl_func != True):
+ return;
f.write("%s GLES2Implementation::%s(%s) {\n" %
(func.return_type, func.original_name,
func.MakeTypedOriginalArgString("")))
@@ -7361,6 +7362,10 @@ TEST_P(%(test_name)s, %(name)sInvalidArgs%(arg_index)d_%(value_index)d) {
def WriteGLES2ImplementationUnitTest(self, func, f):
"""Writes the GLES2 Implemention unit test."""
+ client_test = func.GetInfo('client_test', True)
+ if not client_test:
+ return;
+
code = """
TEST_F(GLES2ImplementationTest, %(name)s) {
%(type)s data[%(count_param)d][%(count)d] = {{0}};
« no previous file with comments | « gpu/GLES2/gl2chromium_autogen.h ('k') | gpu/command_buffer/client/context_support.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698