Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2673453002: Fix DetachableResourceHandler when OnResponseCompleted is deferred. (Closed)

Created:
3 years, 10 months ago by mmenke
Modified:
3 years, 10 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DetachableResourceHandler when OnResponseCompleted is deferred. https://codereview.chromium.org/2526983002/ made it so that when the next ResourceHandler defers OnResponseCompleted, and then the ResourceHandler is detached, DetachableResourceHandler wouldn't tear down the request. This probably never happpens in practice, but it was supported before that CL. BUG=687240 Review-Url: https://codereview.chromium.org/2673453002 Cr-Commit-Position: refs/heads/master@{#447660} Committed: https://chromium.googlesource.com/chromium/src/+/59420d8f9e1521355d98b03cbf2748f7ad0dbb07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/loader/detachable_resource_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
mmenke
csharrison: I do have a test for this (Which is how I found it), but ...
3 years, 10 months ago (2017-02-01 20:24:19 UTC) #2
Charlie Harrison
LGTM this is fine to land imo
3 years, 10 months ago (2017-02-01 23:00:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2673453002/1
3 years, 10 months ago (2017-02-01 23:01:42 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 00:41:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/59420d8f9e1521355d98b03cbf27...

Powered by Google App Engine
This is Rietveld 408576698