Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2660723002: ResourceHandler::OnWillStart: Remove min_size argument. (Closed)

Created:
3 years, 10 months ago by mmenke
Modified:
3 years, 10 months ago
CC:
asanka, Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, loading-reviews_chromium.org, qsr+mojo_chromium.org, Randy Smith (Not in Mondays), viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ResourceHandler::OnWillStart: Remove min_size argument. Nothing sets it to anything but -1, even MimeTypeResourceHandler, the one class that really wants a buffer of at least a certain size. The major ResourceHandler subclasses just DCHECK it's -1, so it serves no purpose. BUG=none Review-Url: https://codereview.chromium.org/2660723002 Cr-Commit-Position: refs/heads/master@{#447791} Committed: https://chromium.googlesource.com/chromium/src/+/7551f612ef47cc7d5eaf27771728cde7e0b51f26

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -154 lines) Patch
M content/browser/download/download_request_core.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/download/download_request_core.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/download/download_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/download/save_file_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/download/save_file_resource_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/download/url_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/async_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/loader/detachable_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/detachable_resource_handler.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/loader/intercepting_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/intercepting_resource_handler.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M content/browser/loader/intercepting_resource_handler_unittest.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M content/browser/loader/layered_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/layered_resource_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/mock_resource_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/mock_resource_loader.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 21 chunks +24 lines, -24 lines 0 comments Download
M content/browser/loader/navigation_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/navigation_resource_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler_unittest.cc View 16 chunks +23 lines, -23 lines 0 comments Download
M content/browser/loader/resource_handler.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/stream_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/stream_resource_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/loader/sync_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/sync_resource_handler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/loader/test_resource_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/test_resource_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/throttling_resource_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
mmenke
I'm having trouble coming up with a comment adequate to the silliness of this CL.
3 years, 10 months ago (2017-01-27 22:02:17 UTC) #4
mmenke
On 2017/01/27 22:02:17, mmenke (Out Feb 4 to March 5) wrote: > I'm having trouble ...
3 years, 10 months ago (2017-01-27 22:03:02 UTC) #5
Charlie Harrison
LOL-worthy LGTM
3 years, 10 months ago (2017-01-27 22:06:09 UTC) #6
mmenke
[+asanka]: Please review content/browser/download.
3 years, 10 months ago (2017-01-30 03:23:33 UTC) #10
asanka
lgtm
3 years, 10 months ago (2017-01-30 21:37:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660723002/40001
3 years, 10 months ago (2017-02-02 16:32:30 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 17:40:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7551f612ef47cc7d5eaf27771728...

Powered by Google App Engine
This is Rietveld 408576698